From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: ebiederm@xmission.com, dwmw2@infradead.org,
netdev@vger.kernel.org, johannes@sipsolutions.net
Subject: Re: tun netns BUG()
Date: Sun, 05 Jul 2009 19:01:37 -0700 (PDT) [thread overview]
Message-ID: <20090705.190137.148499351.davem@davemloft.net> (raw)
In-Reply-To: <20090703152547.GA28755@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Fri, 3 Jul 2009 23:25:47 +0800
> Eric W. Biederman <ebiederm@xmission.com> wrote:
>>
>> Not so.
>>
>> unregister_netdevice
>> rollback_registered
>> tun_net_unit
>> __tun_detach.
>>
>>
>> Further we need rtnl_lock around __tun_detach.
>
> No we don't, tfile->count prevents this from occuring. The async
> path will only __tun_detach if the count hits zero, in which case
> the first if clause in tun_chr_close will fail. Conversely, if
> we're in the first if clause in tun_chr_close, then the async
> path either didn't execute at all or did not call __tun_detach.
I've applied Herbert's patch, thanks!
next prev parent reply other threads:[~2009-07-06 2:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-04 19:05 tun netns BUG() David Woodhouse
2009-06-05 1:19 ` Eric W. Biederman
2009-06-05 8:42 ` David Woodhouse
2009-06-05 9:17 ` David Woodhouse
2009-06-05 23:24 ` Eric W. Biederman
2009-06-06 7:06 ` David Woodhouse
2009-06-08 7:44 ` David Miller
2009-07-03 8:35 ` Herbert Xu
2009-07-03 9:03 ` Herbert Xu
2009-07-03 14:52 ` Eric W. Biederman
2009-07-03 15:25 ` Herbert Xu
2009-07-06 2:01 ` David Miller [this message]
2009-06-05 23:20 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090705.190137.148499351.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dwmw2@infradead.org \
--cc=ebiederm@xmission.com \
--cc=herbert@gondor.apana.org.au \
--cc=johannes@sipsolutions.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).