* [PATCH] dsa: fix 88e6xxx statistics counter snapshotting
@ 2009-07-03 9:26 Lennert Buytenhek
2009-07-06 2:03 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Lennert Buytenhek @ 2009-07-03 9:26 UTC (permalink / raw)
To: davem, netdev; +Cc: stable, Stephane.Contri
From: Stephane Contri <Stephane.Contri@grassvalley.com>
The bit that tells us whether a statistics counter snapshot operation
has completed is located in the GLOBAL register block, not in the
GLOBAL2 register block, so fix up mv88e6xxx_stats_wait() to poll the
right register address.
Signed-off-by: Stephane Contri <Stephane.Contri@grassvalley.com>
Signed-off-by: Lennert Buytenhek <buytenh@marvell.com>
Cc: stable@kernel.org
diff --git a/net/dsa/mv88e6xxx.c b/net/dsa/mv88e6xxx.c
index 4e4d8b5..efe661a 100644
--- a/net/dsa/mv88e6xxx.c
+++ b/net/dsa/mv88e6xxx.c
@@ -418,7 +418,7 @@ static int mv88e6xxx_stats_wait(struct dsa_switch *ds)
int i;
for (i = 0; i < 10; i++) {
- ret = REG_READ(REG_GLOBAL2, 0x1d);
+ ret = REG_READ(REG_GLOBAL, 0x1d);
if ((ret & 0x8000) == 0)
return 0;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dsa: fix 88e6xxx statistics counter snapshotting
2009-07-03 9:26 [PATCH] dsa: fix 88e6xxx statistics counter snapshotting Lennert Buytenhek
@ 2009-07-06 2:03 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2009-07-06 2:03 UTC (permalink / raw)
To: buytenh; +Cc: netdev, stable, Stephane.Contri
From: Lennert Buytenhek <buytenh@wantstofly.org>
Date: Fri, 3 Jul 2009 11:26:48 +0200
> From: Stephane Contri <Stephane.Contri@grassvalley.com>
>
> The bit that tells us whether a statistics counter snapshot operation
> has completed is located in the GLOBAL register block, not in the
> GLOBAL2 register block, so fix up mv88e6xxx_stats_wait() to poll the
> right register address.
>
> Signed-off-by: Stephane Contri <Stephane.Contri@grassvalley.com>
> Signed-off-by: Lennert Buytenhek <buytenh@marvell.com>
Applied, and queued up for -stable.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-07-06 2:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-03 9:26 [PATCH] dsa: fix 88e6xxx statistics counter snapshotting Lennert Buytenhek
2009-07-06 2:03 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).