From: David Miller <davem@davemloft.net>
To: gerg@snapgear.com
Cc: netdev@vger.kernel.org, gerg@uclinux.org, s.hauer@pengutronix.de
Subject: Re: [PATCH] fec: fix definition of 5272 version of FEC_X_DES_ACTIVE register
Date: Mon, 06 Jul 2009 18:52:58 -0700 (PDT) [thread overview]
Message-ID: <20090706.185258.163126816.davem@davemloft.net> (raw)
In-Reply-To: <4A52A6CE.6010509@snapgear.com>
From: Greg Ungerer <gerg@snapgear.com>
Date: Tue, 07 Jul 2009 11:37:18 +1000
> That is not a cleanup patch. It is a bug fix. You cannot build
> with those ";" in there:
Your commit message could have been more explicit about this.
In fact, your commit message was empty. :-/
I'll move that change over to net-2.6 and apply the bug fix for that
one value as well, but you can avoid these kinds of charades in the
future by writing proper, verbose, commit messages.
prev parent reply other threads:[~2009-07-07 1:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-07 1:23 [PATCH] fec: fix definition of 5272 version of FEC_X_DES_ACTIVE register Greg Ungerer
2009-07-07 1:27 ` David Miller
2009-07-07 1:37 ` Greg Ungerer
2009-07-07 1:52 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090706.185258.163126816.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=gerg@snapgear.com \
--cc=gerg@uclinux.org \
--cc=netdev@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox