From: Stephen Hemminger <shemminger@vyatta.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: acme@ghostprotocols.net, davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH] skbuff: don't corrupt mac_header on skb expansion
Date: Mon, 6 Jul 2009 11:23:14 -0700 [thread overview]
Message-ID: <20090706112314.70078b19@nehalam> (raw)
In-Reply-To: <20090705035521.GA7693@gondor.apana.org.au>
On Sun, 5 Jul 2009 11:55:21 +0800
Herbert Xu <herbert@gondor.apana.org.au> wrote:
> Stephen Hemminger <shemminger@vyatta.com> wrote:
> > The skb mac_header field is sometimes NULL (or ~0u) as a sentinel
> > value. The places where skb is expanded add an offset which would
> > change this flag into an invalid pointer (or offset).
> >
> > Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
>
> What uses skb_mac_header_was_set apart from a debugging printk
> in route.c and nfnetlink_log (which is also essentially a debugging
> printk)?
>
> This seems to be a bit much just to make a couple printks work?
>
> What about using mac_len instead to figure out whether the MAC
> header is there?
>
> Cheers,
No worries, either way works, I was just trying to keep acme's original code
--
prev parent reply other threads:[~2009-07-06 18:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-17 22:17 [PATCH] skbuff: don't corrupt mac_header on skb expansion Stephen Hemminger
2009-06-18 1:53 ` David Miller
2009-07-05 3:55 ` Herbert Xu
2009-07-06 18:23 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090706112314.70078b19@nehalam \
--to=shemminger@vyatta.com \
--cc=acme@ghostprotocols.net \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).