netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: pablo.bitton@gmail.com
Cc: davinci-linux-open-source@linux.davincidsp.com, netdev@vger.kernel.org
Subject: Re: [PATCH v2.1] davinci_emac: fix kernel oops when changing MAC address while interface is down
Date: Tue, 07 Jul 2009 19:14:59 -0700 (PDT)	[thread overview]
Message-ID: <20090707.191459.34042463.davem@davemloft.net> (raw)
In-Reply-To: <1246947026.3714.9.camel@desktop-002>

From: Pablo Bitton <pablo.bitton@gmail.com>
Date: Tue, 07 Jul 2009 09:10:26 +0300

> Check that network interface is running before changing its MAC address.
> Otherwise, rxch is accessed when it's NULL - causing a kernel oops.
> Moreover, check that the new MAC address is valid.
> 
> Signed-off-by: Pablo Bitton <pablo.bitton@gmail.com>
> Signed-off-by: Chaithrika U S <chaithrika@ti.com>
> Tested-by: Chaithrika U S <chaithrika@ti.com>
> [tested on DM6467 EVM]

Applied to net-2.6, thanks.

      reply	other threads:[~2009-07-08  2:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-07  6:10 [PATCH v2.1] davinci_emac: fix kernel oops when changing MAC address while interface is down Pablo Bitton
2009-07-08  2:14 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090707.191459.34042463.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=davinci-linux-open-source@linux.davincidsp.com \
    --cc=netdev@vger.kernel.org \
    --cc=pablo.bitton@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).