From: Greg Ungerer <gerg@snapgear.com>
To: netdev@vger.kernel.org
Cc: gerg@uclinux.org, s.hauer@pengutronix.de
Subject: [PATCH] fec: fix definition of 5272 version of FEC_X_DES_ACTIVE register
Date: Tue, 7 Jul 2009 11:23:34 +1000 [thread overview]
Message-ID: <200907070123.n671NY36005818@localhost.localdomain> (raw)
fec: fix definition of 5272 version of FEC_X_DES_ACTIVE register
The ColdFire 5272 FEC driver has a different register address map
than other users of the FEC driver. And its definition of the
FEC_X_DES_ACTIVE register is incorrect, it should be 0x14.
The fec interface cannot transmit data with the old value.
Signed-off-by: Greg Ungerer <gerg@uclinux.org>
----
diff --git a/drivers/net/fec.h b/drivers/net/fec.h
index 6958d85..cc47f3f 100644
--- a/drivers/net/fec.h
+++ b/drivers/net/fec.h
@@ -51,7 +51,7 @@
#define FEC_IMASK 0x008 /* Interrupt mask reg */
#define FEC_IVEC 0x00c /* Interrupt vec status reg */
#define FEC_R_DES_ACTIVE 0x010 /* Receive descriptor reg */
-#define FEC_X_DES_ACTIVE 0x01c /* Transmit descriptor reg */
+#define FEC_X_DES_ACTIVE 0x014 /* Transmit descriptor reg */
#define FEC_MII_DATA 0x040 /* MII manage frame reg */
#define FEC_MII_SPEED 0x044 /* MII speed control reg */
#define FEC_R_BOUND 0x08c /* FIFO receive bound reg */
next reply other threads:[~2009-07-07 1:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-07 1:23 Greg Ungerer [this message]
2009-07-07 1:27 ` [PATCH] fec: fix definition of 5272 version of FEC_X_DES_ACTIVE register David Miller
2009-07-07 1:37 ` Greg Ungerer
2009-07-07 1:52 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200907070123.n671NY36005818@localhost.localdomain \
--to=gerg@snapgear.com \
--cc=gerg@uclinux.org \
--cc=netdev@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox