From: Stephen Hemminger <shemminger@vyatta.com>
To: Anton Vorontsov <avorontsov@ru.mvista.com>
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [PATCH] netpoll: Introduce netpoll_carrier_timeout kernel option
Date: Tue, 7 Jul 2009 18:03:54 -0700 [thread overview]
Message-ID: <20090707180354.2f203648@nehalam> (raw)
In-Reply-To: <20090708010030.GA26331@oksana.dev.rtsoft.ru>
On Wed, 8 Jul 2009 05:00:30 +0400
Anton Vorontsov <avorontsov@ru.mvista.com> wrote:
> Some PHYs require longer timeouts for carrier detection, and
> auto-negotiation process may take indefinite amount of time.
>
> It may be inconvenient to force longer timeouts for sane PHYs,
> so let's introduce a kernel command line option.
>
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> ---
> Documentation/kernel-parameters.txt | 5 +++++
> net/core/netpoll.c | 11 ++++++++++-
> 2 files changed, 15 insertions(+), 1 deletions(-)
A sysctl (or module option) is a less awkward interface for something
like this. Kernel command line parameters are ugly step children
loved only by embedded developers.
next prev parent reply other threads:[~2009-07-08 1:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-08 1:00 [PATCH] netpoll: Introduce netpoll_carrier_timeout kernel option Anton Vorontsov
2009-07-08 1:03 ` Stephen Hemminger [this message]
2009-07-08 1:30 ` [PATCH v2] " Anton Vorontsov
2009-07-08 10:59 ` Neil Horman
2009-07-08 12:23 ` Anton Vorontsov
2009-07-08 18:11 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090707180354.2f203648@nehalam \
--to=shemminger@vyatta.com \
--cc=avorontsov@ru.mvista.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).