From: Divy Le Ray <divy@chelsio.com>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
swise@opengridcomputing.com
Subject: [PATCH 4/8 net-next-2.6] cxgb3: AQ100X phy support update
Date: Tue, 07 Jul 2009 22:48:48 -0700 [thread overview]
Message-ID: <20090708054848.11344.54063.stgit@speedy5> (raw)
In-Reply-To: <20090708054832.11344.82449.stgit@speedy5>
From: Divy Le Ray <divy@chelsio.com>
Add missing SUPPORTED_TP flag.
Update FW version checking.
Do the full initialization even if the FW version is unknown,
it might help catching further issues.
Signed-off-by: Divy Le Ray <divy@chelsio.com>
---
drivers/net/cxgb3/aq100x.c | 7 +++----
1 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/net/cxgb3/aq100x.c b/drivers/net/cxgb3/aq100x.c
index b1fd5bf..341b7ef 100644
--- a/drivers/net/cxgb3/aq100x.c
+++ b/drivers/net/cxgb3/aq100x.c
@@ -271,7 +271,8 @@ int t3_aq100x_phy_prep(struct cphy *phy, struct adapter *adapter, int phy_addr,
cphy_init(phy, adapter, phy_addr, &aq100x_ops, mdio_ops,
SUPPORTED_1000baseT_Full | SUPPORTED_10000baseT_Full |
- SUPPORTED_Autoneg | SUPPORTED_AUI, "1000/10GBASE-T");
+ SUPPORTED_TP | SUPPORTED_Autoneg | SUPPORTED_AUI,
+ "1000/10GBASE-T");
/*
* The PHY has been out of reset ever since the system powered up. So
@@ -316,11 +317,9 @@ int t3_aq100x_phy_prep(struct cphy *phy, struct adapter *adapter, int phy_addr,
/* Firmware version check. */
t3_mdio_read(phy, MDIO_MMD_VEND1, AQ_FW_VERSION, &v);
- if (v != 30) {
+ if (v != 101)
CH_WARN(adapter, "PHY%d: unsupported firmware %d\n",
phy_addr, v);
- return 0; /* allow t3_prep_adapter to succeed */
- }
/*
* The PHY should start in really-low-power mode. Prepare it for normal
next prev parent reply other threads:[~2009-07-08 5:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-08 5:48 [PATCH 1/8 net-next-2.6] cxgb3: Drain Mac Tx fifo when the port goes down Divy Le Ray
2009-07-08 5:48 ` [PATCH 2/8 net-next-2.6] cxgb3: Fix T3C MAC max packet size access Divy Le Ray
2009-07-08 5:48 ` [PATCH 3/8 net-next-2.6] cxgb3: AEL2020 phy support update Divy Le Ray
2009-07-08 5:48 ` Divy Le Ray [this message]
2009-07-08 5:48 ` [PATCH 5/8 net-next-2.6] cxgb3: fix phy power down Divy Le Ray
2009-07-08 5:48 ` [PATCH 6/8 net-next-2.6] cxgb3: Fix mss table initialization Divy Le Ray
2009-07-08 5:49 ` [PATCH 7/8 net-next-2.6] cxgb3: fix mac index mapping Divy Le Ray
2009-07-08 5:49 ` [PATCH 8/8 net-next-2.6] cxgb3: use request_firmware() for the EDC registers setup Divy Le Ray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090708054848.11344.54063.stgit@speedy5 \
--to=divy@chelsio.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=swise@opengridcomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).