From: Stephen Hemminger <shemminger@linux-foundation.org>
To: Mike McCormack <mikem@ring3k.org>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] sky2: Avoid transmitting during sky2_restart()
Date: Sun, 12 Jul 2009 10:18:17 -0700 [thread overview]
Message-ID: <20090712101817.5399f06d@nehalam> (raw)
In-Reply-To: <392fb48f0907112239j4c85932cj3f5f180bb8507143@mail.gmail.com>
On Sun, 12 Jul 2009 14:39:29 +0900
Mike McCormack <mikem@ring3k.org> wrote:
> Hi Stephen,
>
> "ifconfig eth1 up; pktget eth1" will crashed my machine within 10
> seconds. (eth1 is sky2)
> It appears that sky2_tx_timeout causes a restart, and packets in the
> tx queue are free'd twice (once in sky2_status_intr and once in
> sky2_down).
> Furthermore, if sky2_xmit_frame is called during sky2_restart, bad
> things will happen.
>
> This patch fixes both problems and was tested on top of my previous
> sky2_down fix.
>
> thanks,
>
> Mike
This should be fixed by managing the queue properly, not
by using a state flag. I will correct the problem.
next prev parent reply other threads:[~2009-07-12 17:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-12 5:39 [PATCH] sky2: Avoid transmitting during sky2_restart() Mike McCormack
2009-07-12 17:18 ` Stephen Hemminger [this message]
2009-07-13 0:06 ` Mike McCormack
-- strict thread matches above, loose matches on Subject: below --
2009-07-22 12:39 Mike McCormack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090712101817.5399f06d@nehalam \
--to=shemminger@linux-foundation.org \
--cc=mikem@ring3k.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).