From: David Miller <davem@davemloft.net>
To: shemminger@vyatta.com
Cc: aj@open.ch, netdev@vger.kernel.org, kuznet@ms2.inr.ac.ru,
kaber@trash.net
Subject: Re: [PATCH] gre: copy ToS/DiffServ bits to outer IP header
Date: Mon, 13 Jul 2009 09:27:25 -0700 (PDT) [thread overview]
Message-ID: <20090713.092725.90035484.davem@davemloft.net> (raw)
In-Reply-To: <20090713090743.27e1b8ea@nehalam>
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Mon, 13 Jul 2009 09:07:43 -0700
> On Mon, 13 Jul 2009 18:01:42 +0200
> Andreas Jaggi <aj@open.ch> wrote:
>
>> On Mon, Jul 13, 2009 at 08:33:03AM -0700, Stephen Hemminger wrote:
>> > Why make it an option? Sounds like it should always be on.
>>
>> In some scenarios people might want to set the ToS value for all
>> GRE tunnel packets to a fixed value (cf. ip tunnel tos option).
>
> Having more options, does not help users. Why not just do that
> with iptables or classifiers?
I think we should behave however our other IP tunnels behave by
default in this situation.
But regardless, always there is the argument that changing default
behavior is surprising and will bite someone.
next prev parent reply other threads:[~2009-07-13 16:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-13 13:32 [PATCH] gre: copy ToS/DiffServ bits to outer IP header Andreas Jaggi
2009-07-13 15:33 ` Stephen Hemminger
2009-07-13 16:01 ` Andreas Jaggi
2009-07-13 16:07 ` Stephen Hemminger
2009-07-13 16:27 ` David Miller [this message]
2009-07-13 17:44 ` David Miller
2009-07-14 7:14 ` Andreas Jaggi
2009-07-14 16:35 ` David Miller
2009-07-14 14:21 ` Andreas Jaggi
-- strict thread matches above, loose matches on Subject: below --
2009-06-29 13:07 Andreas Jaggi
2009-06-29 13:48 ` Patrick McHardy
2009-06-30 9:05 ` Andreas Jaggi
2009-07-01 10:28 ` Patrick McHardy
2009-06-30 9:06 ` Andreas Jaggi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090713.092725.90035484.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=aj@open.ch \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).