From: David Miller <davem@davemloft.net>
To: aj@open.ch
Cc: netdev@vger.kernel.org, kuznet@ms2.inr.ac.ru, kaber@trash.net
Subject: Re: [PATCH] gre: copy ToS/DiffServ bits to outer IP header
Date: Mon, 13 Jul 2009 10:44:33 -0700 (PDT) [thread overview]
Message-ID: <20090713.104433.244099298.davem@davemloft.net> (raw)
In-Reply-To: <20090713133225.GA20946@urbino.open.ch>
From: Andreas Jaggi <aj@open.ch>
Date: Mon, 13 Jul 2009 15:32:25 +0200
> @@ -24,6 +24,7 @@
> #define GRE_REC __constant_htons(0x0700)
> #define GRE_FLAGS __constant_htons(0x00F8)
> #define GRE_VERSION __constant_htons(0x0007)
> +#define GRE_COPY_TOS __constant_htons(0x0008)
>
> struct ip_tunnel_parm
> {
This seems dangerious, and unnecessary.
If some future RFC defines this flag, we'll have to change
this and add ugly compat code to keep older tools working.
Why not just create a new IFLA_GRE_* attribute to pass in
flags like this that purely are private to the GRE Linux
tunnel driver and have nothing to do with values defined
by GRE tunnel headers at all?
I'm definitely not applying this as-is.
next prev parent reply other threads:[~2009-07-13 17:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-13 13:32 [PATCH] gre: copy ToS/DiffServ bits to outer IP header Andreas Jaggi
2009-07-13 15:33 ` Stephen Hemminger
2009-07-13 16:01 ` Andreas Jaggi
2009-07-13 16:07 ` Stephen Hemminger
2009-07-13 16:27 ` David Miller
2009-07-13 17:44 ` David Miller [this message]
2009-07-14 7:14 ` Andreas Jaggi
2009-07-14 16:35 ` David Miller
2009-07-14 14:21 ` Andreas Jaggi
-- strict thread matches above, loose matches on Subject: below --
2009-06-29 13:07 Andreas Jaggi
2009-06-29 13:48 ` Patrick McHardy
2009-06-30 9:05 ` Andreas Jaggi
2009-07-01 10:28 ` Patrick McHardy
2009-06-30 9:06 ` Andreas Jaggi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090713.104433.244099298.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=aj@open.ch \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).