Re: [ofa-general][PATCH] mlx4_core: Synch catastrophic flow with module unload

[David Miller <davem@davemloft.net>]

From: Roland Dreier <rdreier@cisco.com>
Date: Mon, 13 Jul 2009 12:45:32 -0700

>  > Applied, thanks.
> 
> Dave, please don't apply mlx4_core patches without giving me a chance to
> review them.  In this case the patch looks buggy to me: I don't see how
> it handles, say, hot remove of one device -- it only handles module
> removal.  And I would hope we could fix this without adding a global
> symbol as namespace polluting as "drv_mutex".
> 
> Yevgeny didn't even send this patch to you; he just cc'ed netdev as a
> courtesy.  However I understand that the physical location of mlx4_core
> in drivers/net makes it easy to do this.  Maybe this is the best
> argument in favor of moving the mlx4_core stuff to drivers/shared?

If it gets sent to netdev, it's for a networking driver, and it says
"PATCH" rather than "RFC" or "please review" or "don't apply" you
cannot reasonably expect me to not look into applying the thing.

And if you're saying that patches for this device should start not
going through me, and the tactic to accomplish that is to move the
bulk of the driver into some driver/shared area, that's really weird.

Anyways I didn't push the patch out to kernel.org yet so it's easy for
me to remove it.