netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: kaber@trash.net
Cc: tglx@linutronix.de, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, peterz@infradead.org
Subject: Re: [patch 1/3] net: serialize hrtimer callback in sched_cbq
Date: Tue, 14 Jul 2009 09:01:24 -0700 (PDT)	[thread overview]
Message-ID: <20090714.090124.216664038.davem@davemloft.net> (raw)
In-Reply-To: <4A5C402A.7090906@trash.net>

From: Patrick McHardy <kaber@trash.net>
Date: Tue, 14 Jul 2009 10:22:02 +0200

> That's my understanding what HRTIMER_SOFTIRQ is used for. I think
> simply grabbing the root lock in cbq_undelay() should be fine.
> 
> Compile-tested only.

Unfortunately, as Peter and Thomas explained, this is not the case.

  parent reply	other threads:[~2009-07-14 16:01 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-09 21:59 [patch 0/3] net: Sanitizing hrtimer usage in net/sched/sch_cbq.c Thomas Gleixner
2009-07-09 21:59 ` [patch 1/3] net: serialize hrtimer callback in sched_cbq Thomas Gleixner
2009-07-12 20:55   ` David Miller
2009-07-14  8:22     ` Patrick McHardy
2009-07-14  8:30       ` Peter Zijlstra
2009-07-14 16:01       ` David Miller [this message]
2009-07-14  8:55     ` Thomas Gleixner
2009-07-14 16:00       ` David Miller
2009-07-14 16:28         ` Peter Zijlstra
2009-07-14 16:42           ` Linus Torvalds
2009-07-17 12:14             ` Peter Zijlstra
2009-07-17 13:26               ` Oliver Hartkopp
2009-07-17 15:44               ` Linus Torvalds
2009-07-22  3:18               ` David Miller
2009-07-22  6:29                 ` Peter Zijlstra
2009-07-22 12:28                 ` [PATCH] softirq: tasklet_hrtimer Peter Zijlstra
2009-07-22 15:39                   ` David Miller
2009-07-22 16:01                   ` Linus Torvalds
2009-07-15  9:56         ` [patch 1/3] net: serialize hrtimer callback in sched_cbq Oliver Hartkopp
2009-07-09 21:59 ` [patch 2/3] net: sanitize hrtimer usage " Thomas Gleixner
2009-07-09 21:59 ` [patch 3/3] net: use HRTIMER_RESTART " Thomas Gleixner
2009-07-10  0:39 ` [patch 0/3] net: Sanitizing hrtimer usage in net/sched/sch_cbq.c David Miller
2009-07-12 20:57 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090714.090124.216664038.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=kaber@trash.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).