From: David Miller <davem@davemloft.net>
To: aj@open.ch
Cc: netdev@vger.kernel.org, kuznet@ms2.inr.ac.ru, kaber@trash.net
Subject: Re: [PATCH] gre: copy ToS/DiffServ bits to outer IP header
Date: Tue, 14 Jul 2009 09:35:20 -0700 (PDT) [thread overview]
Message-ID: <20090714.093520.136169461.davem@davemloft.net> (raw)
In-Reply-To: <20090714071410.GA4793@urbino.open.ch>
From: Andreas Jaggi <aj@open.ch>
Date: Tue, 14 Jul 2009 09:14:10 +0200
> On Mon, Jul 13, 2009 at 10:44:33AM -0700, David Miller wrote:
>> Why not just create a new IFLA_GRE_* attribute to pass in
>> flags like this that purely are private to the GRE Linux
>> tunnel driver and have nothing to do with values defined
>> by GRE tunnel headers at all?
>
> OK. What would be an appropriate place to store such a private flag in
> the GRE driver?
>
> I thought of extending the ip_tunnel_parms struct with '__u16 priv_flags'
> (But this would break compatibility with the iproute2 tools?)
You'll need to find a place. Worst case you can make a top-level
new structure, that contains the user interface structure and
then the new __u16 priv_flags thing. And allocate that per-tunnel
instead of what it does now.
next prev parent reply other threads:[~2009-07-14 16:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-13 13:32 [PATCH] gre: copy ToS/DiffServ bits to outer IP header Andreas Jaggi
2009-07-13 15:33 ` Stephen Hemminger
2009-07-13 16:01 ` Andreas Jaggi
2009-07-13 16:07 ` Stephen Hemminger
2009-07-13 16:27 ` David Miller
2009-07-13 17:44 ` David Miller
2009-07-14 7:14 ` Andreas Jaggi
2009-07-14 16:35 ` David Miller [this message]
2009-07-14 14:21 ` Andreas Jaggi
-- strict thread matches above, loose matches on Subject: below --
2009-06-29 13:07 Andreas Jaggi
2009-06-29 13:48 ` Patrick McHardy
2009-06-30 9:05 ` Andreas Jaggi
2009-07-01 10:28 ` Patrick McHardy
2009-06-30 9:06 ` Andreas Jaggi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090714.093520.136169461.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=aj@open.ch \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).