From: David Miller <davem@davemloft.net>
To: dongdong.deng@windriver.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] drivers/net: using spin_lock_irqsave() in net_send_packet()
Date: Tue, 14 Jul 2009 12:35:00 -0700 (PDT) [thread overview]
Message-ID: <20090714.123500.192799902.davem@davemloft.net> (raw)
In-Reply-To: <1247466426-14205-1-git-send-email-dongdong.deng@windriver.com>
From: Dongdong Deng <dongdong.deng@windriver.com>
Date: Mon, 13 Jul 2009 14:27:06 +0800
> spin_unlock_irq() will enable interrupt in net_send_packet(),
> this patch changes it to spin_lock_irqsave/spin_lock_irqrestore,
> so that it doesn't enable interrupts when already disabled,
> and netconsole would work properly over cs89x0/isa-skeleton.
>
> Call trace:
> netconsole write_msg()
> {
> ...
> -> spin_lock_irqsave();
> -> netpoll_send_udp()
> -> netpoll_send_skb()
> -> net_send_packet()
> ->...
>
> -> spin_unlock_irqrestore();
> ...
> }
>
> Signed-off-by: Dongdong Deng <dongdong.deng@windriver.com>
Applied.
prev parent reply other threads:[~2009-07-14 19:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-13 6:27 [PATCH] drivers/net: using spin_lock_irqsave() in net_send_packet() Dongdong Deng
2009-07-14 19:35 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090714.123500.192799902.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dongdong.deng@windriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox