From: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
To: David Miller <davem@davemloft.net>
Cc: aj@open.ch, voyo@no-ip.pl, netdev@vger.kernel.org, kaber@trash.net
Subject: Re: [PATCH] gre: fix ToS/DiffServ inherit bug
Date: Tue, 14 Jul 2009 21:28:47 +0400 [thread overview]
Message-ID: <20090714172847.GA28917@ms2.inr.ac.ru> (raw)
In-Reply-To: <20090714.093433.216171575.davem@davemloft.net>
Hello!
On Tue, Jul 14, 2009 at 09:34:33AM -0700, David Miller wrote:
> Note that this only works out because one wouldn't specify ECN
> bits in the TOS to use for the tunnel.
>
> But it demonstrates the outright danger of trying to use
> "undefined" flag bits in protocol header fields to pass
> private control flags into the driver from user interfaces.
Yes. My fault.
Well, in the form after the patch it will survive at least until
the next change of semantics of tos. :-)
Alexey
prev parent reply other threads:[~2009-07-14 17:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-14 15:36 [PATCH] gre: fix ToS/DiffServ inherit bug Andreas Jaggi
2009-07-14 16:34 ` David Miller
2009-07-14 16:43 ` David Miller
2009-07-14 17:28 ` Alexey Kuznetsov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090714172847.GA28917@ms2.inr.ac.ru \
--to=kuznet@ms2.inr.ac.ru \
--cc=aj@open.ch \
--cc=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=voyo@no-ip.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox