* [PATCH] sky2: revert shutdown changes
@ 2009-07-16 23:20 Stephen Hemminger
2009-07-17 1:10 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Hemminger @ 2009-07-16 23:20 UTC (permalink / raw)
To: David Miller; +Cc: netdev
The commit changes to shutdown path broke startup on some systems.
revert commit c0bad0f2e4366d5bbfe0c4a7a80bca8f4b05272b
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
---
drivers/net/sky2.c | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
--- a/drivers/net/sky2.c 2009-07-07 18:06:44.485898870 -0700
+++ b/drivers/net/sky2.c 2009-07-07 18:14:10.587041228 -0700
@@ -1151,14 +1151,7 @@ stopped:
/* reset the Rx prefetch unit */
sky2_write32(hw, Y2_QADDR(rxq, PREF_UNIT_CTRL), PREF_UNIT_RST_SET);
-
- /* Reset the RAM Buffer receive queue */
- sky2_write8(hw, RB_ADDR(rxq, RB_CTRL), RB_RST_SET);
-
- /* Reset Rx MAC FIFO */
- sky2_write8(hw, SK_REG(sky2->port, RX_GMF_CTRL_T), GMF_RST_SET);
-
- sky2_read8(hw, B0_CTST);
+ mmiowb();
}
/* Clean out receive buffer area, assumes receiver hardware stopped */
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] sky2: revert shutdown changes
2009-07-16 23:20 [PATCH] sky2: revert shutdown changes Stephen Hemminger
@ 2009-07-17 1:10 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2009-07-17 1:10 UTC (permalink / raw)
To: shemminger; +Cc: netdev
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Thu, 16 Jul 2009 16:20:57 -0700
> The commit changes to shutdown path broke startup on some systems.
>
> revert commit c0bad0f2e4366d5bbfe0c4a7a80bca8f4b05272b
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-07-17 1:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-16 23:20 [PATCH] sky2: revert shutdown changes Stephen Hemminger
2009-07-17 1:10 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).