From: Stephen Hemminger <shemminger@vyatta.com>
To: serue@us.ibm.com
Cc: David Miller <davem@davemloft.net>,
containers@lists.osdl.org, sachinp@in.ibm.com,
netdev@vger.kernel.org, matthltc@us.ibm.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] veth: don't free priv->status until dev->destructor (v2)
Date: Mon, 20 Jul 2009 14:25:42 -0700 [thread overview]
Message-ID: <20090720142542.4fb12c12@nehalam> (raw)
In-Reply-To: <20090715.085012.223420354.davem@davemloft.net>
On Wed, 15 Jul 2009 08:50:12 -0700 (PDT)
David Miller <davem@davemloft.net> wrote:
> From: "Serge E. Hallyn" <serue@us.ibm.com>
> Date: Fri, 26 Jun 2009 11:24:18 -0500
>
> > I haven't been able to reproduce the original oops though (been
> > trying to cat the stats sysfs files while rmmoding veth, to no
> > avail, and haven't found an original bug report or testcase), so
> > can't verify whether this patch prevents the original oops.
>
> If you 'cat' it you're unlikely to trigger the oops.
>
> You have to hold the sysfs files open, and then elsewhere do the
> rmmod, wait, and then continue with some access to those open sysfs
> file descriptors (f.e. do some reads).
>
> I'd also need this patch to be against current sources as they'll
> never apply since I did the revert quite some time ago.
>
> Thanks.
My usual way of doing this is:
# (sleep 30; cat /sys/class/net/ethX/statistics/tx_bytes) &
# rmmod the_buggy_driver
wait...
--
next prev parent reply other threads:[~2009-07-20 21:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-26 16:24 [PATCH 1/1] veth: don't free priv->status until dev->destructor (v2) Serge E. Hallyn
2009-07-15 15:50 ` David Miller
2009-07-20 21:25 ` Stephen Hemminger [this message]
2009-07-22 15:55 ` Serge E. Hallyn
2009-07-24 19:46 ` Stephen Hemminger
2009-08-05 6:40 ` Eric W. Biederman
2009-08-05 17:10 ` Stephen Hemminger
2009-08-05 22:43 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090720142542.4fb12c12@nehalam \
--to=shemminger@vyatta.com \
--cc=containers@lists.osdl.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=matthltc@us.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=sachinp@in.ibm.com \
--cc=serue@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).