From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH 4/10] drivers/net: Move a dereference below a NULL test Date: Tue, 21 Jul 2009 13:01:32 -0700 (PDT) Message-ID: <20090721.130132.152098027.davem@davemloft.net> References: Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: eilong@broadcom.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org To: julia@diku.dk Return-path: Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:41229 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755681AbZGUUB1 (ORCPT ); Tue, 21 Jul 2009 16:01:27 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: From: Julia Lawall Date: Sun, 19 Jul 2009 17:26:35 +0200 (CEST) > From: Julia Lawall > > If the NULL test is necessary, then the dereference should be moved below > the NULL test. > > The semantic patch that makes this change is as follows: > (http://www.emn.fr/x-info/coccinelle/) ... > Signed-off-by: Julia Lawall Applied.