From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: PATCH: veth: Zero timestamp in xmit path. Date: Tue, 21 Jul 2009 13:05:42 -0700 (PDT) Message-ID: <20090721.130542.158855009.davem@davemloft.net> References: <4A661B2F.7000608@candelatech.com> <20090721.125155.168882282.davem@davemloft.net> <4A661EBA.7040206@candelatech.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: greearb@candelatech.com Return-path: Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:37036 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755548AbZGUUFg (ORCPT ); Tue, 21 Jul 2009 16:05:36 -0400 In-Reply-To: <4A661EBA.7040206@candelatech.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Ben Greear Date: Tue, 21 Jul 2009 13:02:02 -0700 > On 07/21/2009 12:51 PM, David Miller wrote: >> From: Ben Greear >> Date: Tue, 21 Jul 2009 12:46:55 -0700 >> >>> Signed-Off-By: Ben Greear >> >> Oh, where to begin... sigh... >> >> The "off" and "by" in "Signed-off-by" is not capitalized. >> >> There should not be two spaces after the Signed-off-by colon, there >> should be only one. >> >> There should be a space between your name and your<> enclosed email >> address. > > I had no idea that was so important. If you aren't even going to check over such easy and trivial visual matters such as this, one can only imagine how much care has been put into the change itself. It shows how much you care about how your work and submissions look to other people. It's as much an issue of what it shows about the submitter's overall mentality as it is an issue of "does it matter" or how important it is to get the signoff syntax correct.