From: Dave Jones <davej@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [0/4] trivial cleanups for via-velocity.c
Date: Tue, 21 Jul 2009 15:27:42 -0400 [thread overview]
Message-ID: <20090721192741.GA3831@redhat.com> (raw)
In-Reply-To: <20090721.111235.211304996.davem@davemloft.net>
On Tue, Jul 21, 2009 at 11:12:35AM -0700, David Miller wrote:
> From: Dave Jones <davej@redhat.com>
> Date: Mon, 20 Jul 2009 23:34:56 -0400
>
> > I've had these sitting around for a while, they should be safe to apply.
> > I checked a diff of the disassembly from objdump before/after, and
> > the only diffs were the placement of the functions & jump offsets changing
> > due to the reordering in diff 3/4.
>
> These do not apply to the driver in the current tree, particularly
> it doesn't apply at all to net-next-2.6 which is where I would
> add this.
>
> Please fix this up and resubmit, thanks.
Actually only 1/4 needs rediffing. It removes the only line that changes
in via-velocity in net-next. I'll send a rediff.
thanks,
Dave
prev parent reply other threads:[~2009-07-21 19:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-21 3:34 [0/4] trivial cleanups for via-velocity.c Dave Jones
2009-07-21 18:12 ` David Miller
2009-07-21 19:27 ` Dave Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090721192741.GA3831@redhat.com \
--to=davej@redhat.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).