* [0/4] trivial cleanups for via-velocity.c
@ 2009-07-21 3:34 Dave Jones
2009-07-21 18:12 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Dave Jones @ 2009-07-21 3:34 UTC (permalink / raw)
To: netdev
I've had these sitting around for a while, they should be safe to apply.
I checked a diff of the disassembly from objdump before/after, and
the only diffs were the placement of the functions & jump offsets changing
due to the reordering in diff 3/4.
Dave
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [0/4] trivial cleanups for via-velocity.c
2009-07-21 3:34 [0/4] trivial cleanups for via-velocity.c Dave Jones
@ 2009-07-21 18:12 ` David Miller
2009-07-21 19:27 ` Dave Jones
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2009-07-21 18:12 UTC (permalink / raw)
To: davej; +Cc: netdev
From: Dave Jones <davej@redhat.com>
Date: Mon, 20 Jul 2009 23:34:56 -0400
> I've had these sitting around for a while, they should be safe to apply.
> I checked a diff of the disassembly from objdump before/after, and
> the only diffs were the placement of the functions & jump offsets changing
> due to the reordering in diff 3/4.
These do not apply to the driver in the current tree, particularly
it doesn't apply at all to net-next-2.6 which is where I would
add this.
Please fix this up and resubmit, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [0/4] trivial cleanups for via-velocity.c
2009-07-21 18:12 ` David Miller
@ 2009-07-21 19:27 ` Dave Jones
0 siblings, 0 replies; 3+ messages in thread
From: Dave Jones @ 2009-07-21 19:27 UTC (permalink / raw)
To: David Miller; +Cc: netdev
On Tue, Jul 21, 2009 at 11:12:35AM -0700, David Miller wrote:
> From: Dave Jones <davej@redhat.com>
> Date: Mon, 20 Jul 2009 23:34:56 -0400
>
> > I've had these sitting around for a while, they should be safe to apply.
> > I checked a diff of the disassembly from objdump before/after, and
> > the only diffs were the placement of the functions & jump offsets changing
> > due to the reordering in diff 3/4.
>
> These do not apply to the driver in the current tree, particularly
> it doesn't apply at all to net-next-2.6 which is where I would
> add this.
>
> Please fix this up and resubmit, thanks.
Actually only 1/4 needs rediffing. It removes the only line that changes
in via-velocity in net-next. I'll send a rediff.
thanks,
Dave
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-07-21 19:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-21 3:34 [0/4] trivial cleanups for via-velocity.c Dave Jones
2009-07-21 18:12 ` David Miller
2009-07-21 19:27 ` Dave Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).