From: David Miller <davem@davemloft.net>
To: shemminger@vyatta.com
Cc: rjw@sisk.pl, netdev@vger.kernel.org,
linux-pm@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, mike@it-loops.com
Subject: Re: [PATCH] NET / skge: Enable WoL by default if supported
Date: Wed, 22 Jul 2009 11:25:17 -0700 (PDT) [thread overview]
Message-ID: <20090722.112517.31647761.davem@davemloft.net> (raw)
In-Reply-To: <20090722095953.0806bea2@nehalam>
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Wed, 22 Jul 2009 09:59:53 -0700
> On Wed, 22 Jul 2009 14:58:55 +0200
> "Rafael J. Wysocki" <rjw@sisk.pl> wrote:
>
>> From: Rafael J. Wysocki <rjw@sisk.pl>
>>
>> If skge hardware is capable of waking up the system from sleep,
>> enable magic packet WoL during driver initialisation.
>>
>> This makes WoL work without calling 'ethtool -s ethX wol g'
>> for each adapter.
>>
>> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
>> Tested-by: Michael Guntsche <mike@it-loops.com>
>> ---
>> drivers/net/skge.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> Index: linux-2.6/drivers/net/skge.c
>> ===================================================================
>> --- linux-2.6.orig/drivers/net/skge.c
>> +++ linux-2.6/drivers/net/skge.c
>> @@ -3856,8 +3856,10 @@ static struct net_device *skge_devinit(s
>> skge->speed = -1;
>> skge->advertising = skge_supported_modes(hw);
>>
>> - if (device_may_wakeup(&hw->pdev->dev))
>> + if (device_can_wakeup(&hw->pdev->dev)) {
>> skge->wol = wol_supported(hw) & WAKE_MAGIC;
>> + device_set_wakeup_enable(&hw->pdev->dev, skge->wol);
>> + }
>>
>> hw->dev[port] = dev;
>>
>
> Acked-by: Stephen Hemminger <shemminger@vyatta.com>
Applied, thanks.
prev parent reply other threads:[~2009-07-22 18:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-22 12:58 [PATCH] NET / skge: Enable WoL by default if supported Rafael J. Wysocki
2009-07-22 16:59 ` Stephen Hemminger
2009-07-22 18:25 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090722.112517.31647761.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=mike@it-loops.com \
--cc=netdev@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).