From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] be2net: Adding support for 802.1ad (q-in-q mode) Date: Thu, 23 Jul 2009 10:01:24 -0700 (PDT) Message-ID: <20090723.100124.169341665.davem@davemloft.net> References: <4A6837A8.9040208@trash.net> <20090723.092301.115261115.davem@davemloft.net> <4A6890C1.2000108@trash.net> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: sarveshwarb@serverengines.com, netdev@vger.kernel.org To: kaber@trash.net Return-path: Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:43741 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754500AbZGWRBS (ORCPT ); Thu, 23 Jul 2009 13:01:18 -0400 In-Reply-To: <4A6890C1.2000108@trash.net> Sender: netdev-owner@vger.kernel.org List-ID: From: Patrick McHardy Date: Thu, 23 Jul 2009 18:33:05 +0200 > David Miller wrote: >>> Sarveshwar Bandi wrote: >>>> The outer vlan is totally transparent to the host. It is used by the NIC >>>> to demux packets across multiple pci network functions. Currently the >>>> outer vlan tags are configured on the NIC by OEM provided utilities. >>> I see. A proper changelog entry would have explained that and avoided >>> all this confusion. Not that I think using another tool for this is a >>> good solution, but no objections from a functional POV. >> >> Using OEM tools makes no sense, there should be something like an >> ethtool interface for changing this setting and appropriate changes >> to the common userland tools to provide access to them. >> >> I'm not putting this change in until there is common infrastructure >> submitted to common tools to control this configuration. > > Thanks, thats my opinion as well. But I think we should handle > Q-in-Q using the VLAN netlink API and iproute instead of ethtool > for consistency. That works for me too.