netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: jeffrey.t.kirsher@intel.com
Cc: netdev@vger.kernel.org, gospo@redhat.com, lucy.liu@intel.com,
	peter.p.waskiewicz.jr@intel.com
Subject: Re: [net-2.6 PATCH 2/2] ixgbe: Don't priority tag control frames in DCB mode
Date: Thu, 23 Jul 2009 11:06:14 -0700 (PDT)	[thread overview]
Message-ID: <20090723.110614.180424233.davem@davemloft.net> (raw)
In-Reply-To: <20090723000733.27299.56014.stgit@localhost.localdomain>

From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Wed, 22 Jul 2009 17:07:33 -0700

> From: Lucy Liu <lucy.liu@intel.com>
> 
> Certain types of control packets (LLDP, LACP, etc.) are not supposed to have a
> priority tag or vlan tag inserted.  Ixgbe driver is currently priority
> tagging everything (if packet is not on a VLAN interface).
> 
> This patch modifies DCB mode, so that packets marked with skb priority
> TC_PRIO_CONTROL are not priority tagged.  It also transmits these packets on
> the highest priority traffic class.
> Programs (like dcbd) can set the skb priority using a socket option.  Or, a tc
> filter can be configured to set the priority value. Using the value
> TC_PRIO_CONTROL (7) has the benefit that it is already defined in the kernel,
> and the bonding LACP code already sets the skb->priority field to this value.
> 
> Signed-off-by: Lucy Liu <lucy.liu@intel.com>
> Acked-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>

Applied.

  reply	other threads:[~2009-07-23 18:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-23  0:07 [net-2.6 PATCH 1/2] ixgbe: Enable FCoE offload when DCB is enabled for 82599 Jeff Kirsher
2009-07-23  0:07 ` [net-2.6 PATCH 2/2] ixgbe: Don't priority tag control frames in DCB mode Jeff Kirsher
2009-07-23 18:06   ` David Miller [this message]
2009-07-23 18:06 ` [net-2.6 PATCH 1/2] ixgbe: Enable FCoE offload when DCB is enabled for 82599 David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090723.110614.180424233.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=gospo@redhat.com \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=lucy.liu@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=peter.p.waskiewicz.jr@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).