* [PATCH] at1700: Read buffer overflow
@ 2009-07-25 22:01 Roel Kluin
2009-07-27 2:01 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Roel Kluin @ 2009-07-25 22:01 UTC (permalink / raw)
To: David S. Miller, netdev, Andrew Morton
loop bound looks to be wrong, for an array of length 8
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
Or is a value is missing? (others contrastingly end with `, 0')
diff --git a/drivers/net/at1700.c b/drivers/net/at1700.c
index 18b566a..cf30e27 100644
--- a/drivers/net/at1700.c
+++ b/drivers/net/at1700.c
@@ -318,7 +318,7 @@ static int __init at1700_probe1(struct net_device *dev, int ioaddr)
pos3 = mca_read_stored_pos( slot, 3 );
pos4 = mca_read_stored_pos( slot, 4 );
- for (l_i = 0; l_i < 0x09; l_i++)
+ for (l_i = 0; l_i < 8; l_i++)
if (( pos3 & 0x07) == at1700_ioaddr_pattern[l_i])
break;
ioaddr = at1700_mca_probe_list[l_i];
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] at1700: Read buffer overflow
2009-07-25 22:01 [PATCH] at1700: Read buffer overflow Roel Kluin
@ 2009-07-27 2:01 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2009-07-27 2:01 UTC (permalink / raw)
To: roel.kluin; +Cc: netdev, akpm
From: Roel Kluin <roel.kluin@gmail.com>
Date: Sun, 26 Jul 2009 00:01:50 +0200
> loop bound looks to be wrong, for an array of length 8
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-07-27 2:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-25 22:01 [PATCH] at1700: Read buffer overflow Roel Kluin
2009-07-27 2:01 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).