* [PATCH] sky2: remove unnecessary assignment
@ 2009-07-22 0:51 Mike McCormack
2009-07-22 16:58 ` Stephen Hemminger
2009-07-22 16:59 ` Stephen Hemminger
0 siblings, 2 replies; 6+ messages in thread
From: Mike McCormack @ 2009-07-22 0:51 UTC (permalink / raw)
To: netdev; +Cc: Stephen Hemminger
Signed-off-by: Mike McCormack <mikem@ring3k.org>
---
drivers/net/sky2.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/sky2.c b/drivers/net/sky2.c
index 3550c5d..661abd0 100644
--- a/drivers/net/sky2.c
+++ b/drivers/net/sky2.c
@@ -4117,7 +4117,7 @@ static int sky2_debug_show(struct seq_file *seq, void *v)
seq_printf(seq, "\nRx ring hw get=%d put=%d last=%d\n",
sky2_read16(hw, Y2_QADDR(rxqaddr[port], PREF_UNIT_GET_IDX)),
- last = sky2_read16(hw, Y2_QADDR(rxqaddr[port], PREF_UNIT_PUT_IDX)),
+ sky2_read16(hw, Y2_QADDR(rxqaddr[port], PREF_UNIT_PUT_IDX)),
sky2_read16(hw, Y2_QADDR(rxqaddr[port], PREF_UNIT_LAST_IDX)));
sky2_read32(hw, B0_Y2_SP_LISR);
--
1.5.6.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] sky2: remove unnecessary assignment
2009-07-22 0:51 [PATCH] sky2: remove unnecessary assignment Mike McCormack
@ 2009-07-22 16:58 ` Stephen Hemminger
2009-07-22 16:59 ` Stephen Hemminger
1 sibling, 0 replies; 6+ messages in thread
From: Stephen Hemminger @ 2009-07-22 16:58 UTC (permalink / raw)
To: Mike McCormack; +Cc: netdev
On Wed, 22 Jul 2009 09:51:20 +0900
Mike McCormack <mikem@ring3k.org> wrote:
> Signed-off-by: Mike McCormack <mikem@ring3k.org>
> ---
> drivers/net/sky2.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/sky2.c b/drivers/net/sky2.c
> index 3550c5d..661abd0 100644
> --- a/drivers/net/sky2.c
> +++ b/drivers/net/sky2.c
> @@ -4117,7 +4117,7 @@ static int sky2_debug_show(struct seq_file *seq, void *v)
>
> seq_printf(seq, "\nRx ring hw get=%d put=%d last=%d\n",
> sky2_read16(hw, Y2_QADDR(rxqaddr[port], PREF_UNIT_GET_IDX)),
> - last = sky2_read16(hw, Y2_QADDR(rxqaddr[port], PREF_UNIT_PUT_IDX)),
> + sky2_read16(hw, Y2_QADDR(rxqaddr[port], PREF_UNIT_PUT_IDX)),
> sky2_read16(hw, Y2_QADDR(rxqaddr[port], PREF_UNIT_LAST_IDX)));
>
> sky2_read32(hw, B0_Y2_SP_LISR);
Acked-by: Stephen Hemminger <shemminger@vyatta.com>
--
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] sky2: remove unnecessary assignment
2009-07-22 0:51 [PATCH] sky2: remove unnecessary assignment Mike McCormack
2009-07-22 16:58 ` Stephen Hemminger
@ 2009-07-22 16:59 ` Stephen Hemminger
2009-07-27 2:07 ` David Miller
1 sibling, 1 reply; 6+ messages in thread
From: Stephen Hemminger @ 2009-07-22 16:59 UTC (permalink / raw)
To: Mike McCormack; +Cc: netdev
On Wed, 22 Jul 2009 09:51:20 +0900
Mike McCormack <mikem@ring3k.org> wrote:
> Signed-off-by: Mike McCormack <mikem@ring3k.org>
> ---
> drivers/net/sky2.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/sky2.c b/drivers/net/sky2.c
> index 3550c5d..661abd0 100644
> --- a/drivers/net/sky2.c
> +++ b/drivers/net/sky2.c
> @@ -4117,7 +4117,7 @@ static int sky2_debug_show(struct seq_file *seq, void *v)
>
> seq_printf(seq, "\nRx ring hw get=%d put=%d last=%d\n",
> sky2_read16(hw, Y2_QADDR(rxqaddr[port], PREF_UNIT_GET_IDX)),
> - last = sky2_read16(hw, Y2_QADDR(rxqaddr[port], PREF_UNIT_PUT_IDX)),
> + sky2_read16(hw, Y2_QADDR(rxqaddr[port], PREF_UNIT_PUT_IDX)),
> sky2_read16(hw, Y2_QADDR(rxqaddr[port], PREF_UNIT_LAST_IDX)));
>
> sky2_read32(hw, B0_Y2_SP_LISR);
Acked-by: Stephen Hemminger <shemminger@vyatta.com>
--
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] sky2: remove unnecessary assignment
@ 2009-07-23 2:53 Mike McCormack
2009-07-23 4:04 ` David Miller
0 siblings, 1 reply; 6+ messages in thread
From: Mike McCormack @ 2009-07-23 2:53 UTC (permalink / raw)
To: netdev
Signed-off-by: Mike McCormack <mikem@ring3k.org>
Acked-by: Stephen Hemminger <shemminger@vyatta.com>
---
drivers/net/sky2.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/sky2.c b/drivers/net/sky2.c
index 3550c5d..661abd0 100644
--- a/drivers/net/sky2.c
+++ b/drivers/net/sky2.c
@@ -4117,7 +4117,7 @@ static int sky2_debug_show(struct seq_file *seq, void *v)
seq_printf(seq, "\nRx ring hw get=%d put=%d last=%d\n",
sky2_read16(hw, Y2_QADDR(rxqaddr[port], PREF_UNIT_GET_IDX)),
- last = sky2_read16(hw, Y2_QADDR(rxqaddr[port], PREF_UNIT_PUT_IDX)),
+ sky2_read16(hw, Y2_QADDR(rxqaddr[port], PREF_UNIT_PUT_IDX)),
sky2_read16(hw, Y2_QADDR(rxqaddr[port], PREF_UNIT_LAST_IDX)));
sky2_read32(hw, B0_Y2_SP_LISR);
--
1.5.6.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] sky2: remove unnecessary assignment
2009-07-23 2:53 Mike McCormack
@ 2009-07-23 4:04 ` David Miller
0 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2009-07-23 4:04 UTC (permalink / raw)
To: mikem; +Cc: netdev
From: Mike McCormack <mikem@ring3k.org>
Date: Thu, 23 Jul 2009 11:53:58 +0900
> Signed-off-by: Mike McCormack <mikem@ring3k.org>
> Acked-by: Stephen Hemminger <shemminger@vyatta.com>
When people ACK your patches and they are still in
"Under Review" state in patchwork, you DO NOT have
to resend the patch.
When I grab it out of patchwork and apply it to my
tree patchwork has seen all of the Acked-by and other
tags in the replies and puts it into the commit
message for me.
By resending this you're making MORE work for me, not
LESS.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2009-07-27 2:07 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-22 0:51 [PATCH] sky2: remove unnecessary assignment Mike McCormack
2009-07-22 16:58 ` Stephen Hemminger
2009-07-22 16:59 ` Stephen Hemminger
2009-07-27 2:07 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2009-07-23 2:53 Mike McCormack
2009-07-23 4:04 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).