* Re: [PATCH 1/2] NET: NETROM: Don't use static buffer. [not found] ` <65cb898f276a2dc3c56e6a78b5bc422303e6856f.1248620197.git.ralf@linux-mips.org> @ 2009-07-27 2:09 ` David Miller 2009-08-04 18:57 ` David Miller 0 siblings, 1 reply; 3+ messages in thread From: David Miller @ 2009-07-27 2:09 UTC (permalink / raw) To: ralf; +Cc: netdev, linux-hams From: Ralf Baechle <ralf@linux-mips.org> Date: Sat, 25 Jul 2009 11:38:17 +0100 > The use of a static buffer in nr_call_to_digi() to return its result is > not threadproof and can result in corruption if multiple threads are > trying to perform SIOCADDRT ioctls. > > Signed-off-by: Ralf Baechle <ralf@linux-mips.org> So what frees up these now-dynamically-allocated digi objects? ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] NET: NETROM: Don't use static buffer. 2009-07-27 2:09 ` [PATCH 1/2] NET: NETROM: Don't use static buffer David Miller @ 2009-08-04 18:57 ` David Miller 0 siblings, 0 replies; 3+ messages in thread From: David Miller @ 2009-08-04 18:57 UTC (permalink / raw) To: ralf; +Cc: netdev, linux-hams From: David Miller <davem@davemloft.net> Date: Sun, 26 Jul 2009 19:09:27 -0700 (PDT) > From: Ralf Baechle <ralf@linux-mips.org> > Date: Sat, 25 Jul 2009 11:38:17 +0100 > >> The use of a static buffer in nr_call_to_digi() to return its result is >> not threadproof and can result in corruption if multiple threads are >> trying to perform SIOCADDRT ioctls. >> >> Signed-off-by: Ralf Baechle <ralf@linux-mips.org> > > So what frees up these now-dynamically-allocated digi objects? Ralf, ping? ^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <eb5a7590d64932b2239e358b54391c25007472ee.1248620197.git.ralf@linux-mips.org>]
* Re: [PATCH 2/2] NET: ROSE: Don't use static buffer. [not found] ` <eb5a7590d64932b2239e358b54391c25007472ee.1248620197.git.ralf@linux-mips.org> @ 2009-07-27 2:11 ` David Miller 0 siblings, 0 replies; 3+ messages in thread From: David Miller @ 2009-07-27 2:11 UTC (permalink / raw) To: ralf; +Cc: netdev, linux-hams From: Ralf Baechle <ralf@linux-mips.org> Date: Sat, 25 Jul 2009 11:38:18 +0100 > The use of a static buffer in rose2asc() to return its result is not > threadproof and can result in corruption if multiple threads are trying > to use one of the procfs files based on rose2asc(). > > Signed-off-by: Ralf Baechle <ralf@linux-mips.org> Looks good, applied, thanks! ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-08-04 18:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <cover.1248620197.git.ralf@linux-mips.org>
[not found] ` <65cb898f276a2dc3c56e6a78b5bc422303e6856f.1248620197.git.ralf@linux-mips.org>
2009-07-27 2:09 ` [PATCH 1/2] NET: NETROM: Don't use static buffer David Miller
2009-08-04 18:57 ` David Miller
[not found] ` <eb5a7590d64932b2239e358b54391c25007472ee.1248620197.git.ralf@linux-mips.org>
2009-07-27 2:11 ` [PATCH 2/2] NET: ROSE: " David Miller
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).