From: David Miller <davem@davemloft.net>
To: andi@firstfloor.org
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] Add some function overview comments in tcp_input.c
Date: Sun, 26 Jul 2009 19:23:21 -0700 (PDT) [thread overview]
Message-ID: <20090726.192321.257422911.davem@davemloft.net> (raw)
In-Reply-To: <20090724094719.GA19200@basil.fritz.box>
From: Andi Kleen <andi@firstfloor.org>
Date: Fri, 24 Jul 2009 11:47:19 +0200
> Add some function overview comments in tcp_input.c
>
> Only partial so far. I didn't attempt to accurately comment
> the SACK machinery and the congestion state machine.
>
> I also fixed the grammar in one or two other comments
> (but still trying to keep the authentic "ANK language" @)
>
> No code changes.
>
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
Most of your comments sound exactly the same as what I
hear when I say the function's name out loud.
That's worse than wasted space.
What's the chapter from The Practice of Programming where
they advise against this with a bunch of amusing examples?
:-)
I'm not applying this, sorry.
next prev parent reply other threads:[~2009-07-27 2:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-24 9:47 [PATCH] Add some function overview comments in tcp_input.c Andi Kleen
2009-07-27 2:23 ` David Miller [this message]
2009-07-27 12:48 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090726.192321.257422911.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andi@firstfloor.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).