From: David Miller <davem@davemloft.net>
To: jeffrey.t.kirsher@intel.com
Cc: netdev@vger.kernel.org, gospo@redhat.com, donald.c.skidmore@intel.com
Subject: Re: [net-2.6 PATCH] ixgbe: fix for 82599 errata marking UDP checksum errors
Date: Sun, 26 Jul 2009 20:21:54 -0700 (PDT) [thread overview]
Message-ID: <20090726.202154.00452824.davem@davemloft.net> (raw)
In-Reply-To: <20090724040031.30202.1531.stgit@localhost.localdomain>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Thu, 23 Jul 2009 21:00:39 -0700
> From: Don Skidmore <donald.c.skidmore@intel.com>
>
> There is an 82599 errata that UDP frames with a zero checksum are
> incorrectly marked as checksum invalid by the hardware. This was
> leading to misleading hw_csum_rx_error counts. This patch adds a
> test around this counter increase for this condition.
>
> Signed-off-by: Don Skidmore <donald.c.skidmore@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied, thanks.
But I wonder. When you compute a checksum, and it's zero,
you have to use the complement as the checksum value. How
does that relate to the problem being tackled here?
next prev parent reply other threads:[~2009-07-27 3:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-24 4:00 [net-2.6 PATCH] ixgbe: fix for 82599 errata marking UDP checksum errors Jeff Kirsher
2009-07-27 3:21 ` David Miller [this message]
2009-07-27 6:11 ` Waskiewicz Jr, Peter P
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090726.202154.00452824.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=donald.c.skidmore@intel.com \
--cc=gospo@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).