net-next-2.6 phonet causes build error

net-next-2.6 phonet causes build error

[Oliver Hartkopp]

Hi Remi,

i got this build error from the latest net-next-2.6:

net/phonet/pn_dev.c: In function ‘phonet_init_net’:
net/phonet/pn_dev.c:221: error: implicit declaration of function
‘proc_net_fops_create’
net/phonet/pn_dev.c: In function ‘phonet_exit_net’:
net/phonet/pn_dev.c:242: error: implicit declaration of function ‘proc_net_remove’

Regards,
Oliver

Re: net-next-2.6 phonet causes build error

[David Miller]

From: Oliver Hartkopp <oliver@hartkopp.net>
Date: Sun, 26 Jul 2009 20:43:11 +0200

> Hi Remi,
> 
> i got this build error from the latest net-next-2.6:
> 
> net/phonet/pn_dev.c: In function ‘phonet_init_net’:
> net/phonet/pn_dev.c:221: error: implicit declaration of function
> ‘proc_net_fops_create’
> net/phonet/pn_dev.c: In function ‘phonet_exit_net’:
> net/phonet/pn_dev.c:242: error: implicit declaration of function ‘proc_net_remove’

I just committed the following fix for this:

phonet: Fix build.

As reported by Oliver Hartkopp:

net/phonet/pn_dev.c: In function ‘phonet_init_net’:
net/phonet/pn_dev.c:221: error: implicit declaration of function
‘proc_net_fops_create’
net/phonet/pn_dev.c: In function ‘phonet_exit_net’:
net/phonet/pn_dev.c:242: error: implicit declaration of function ‘proc_net_remove’

Signed-off-by: David S. Miller <davem@davemloft.net>
---
 net/phonet/pn_dev.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/net/phonet/pn_dev.c b/net/phonet/pn_dev.c
index 5107b79..6b30cc1 100644
--- a/net/phonet/pn_dev.c
+++ b/net/phonet/pn_dev.c
@@ -27,6 +27,7 @@
 #include <linux/net.h>
 #include <linux/netdevice.h>
 #include <linux/phonet.h>
+#include <linux/proc_fs.h>
 #include <net/sock.h>
 #include <net/netns/generic.h>
 #include <net/phonet/pn_dev.h>
-- 
1.6.3.3

Re: net-next-2.6 phonet causes build error

[Rémi Denis-Courmont]

On Sunday 26 July 2009 21:43:11 ext Oliver Hartkopp wrote:
> i got this build error from the latest net-next-2.6:
>
> net/phonet/pn_dev.c: In function ‘phonet_init_net’:
> net/phonet/pn_dev.c:221: error: implicit declaration of function
> ‘proc_net_fops_create’
> net/phonet/pn_dev.c: In function ‘phonet_exit_net’:
> net/phonet/pn_dev.c:242: error: implicit declaration of function
> ‘proc_net_remove’

Oops. This makes me wonder why I did not get that one here on my test 
builds???

-- 
Rémi Denis-Courmont
Nokia Devices R&D, Maemo Software, Helsinki

Re: net-next-2.6 phonet causes build error

[Eric Dumazet]

Rémi Denis-Courmont a écrit :
> On Sunday 26 July 2009 21:43:11 ext Oliver Hartkopp wrote:
>> i got this build error from the latest net-next-2.6:
>>
>> net/phonet/pn_dev.c: In function ‘phonet_init_net’:
>> net/phonet/pn_dev.c:221: error: implicit declaration of function
>> ‘proc_net_fops_create’
>> net/phonet/pn_dev.c: In function ‘phonet_exit_net’:
>> net/phonet/pn_dev.c:242: error: implicit declaration of function
>> ‘proc_net_remove’
> 
> Oops. This makes me wonder why I did not get that one here on my test 
> builds???
> 

I also have this warning :

net/phonet/pn_dev.c: In function `phonet_device_get':
net/phonet/pn_dev.c:99: warning: 'dev' might be used uninitialized in this function

What about following patch ?

[PATCH] phonet: phonet_device_get() fix

net/phonet/pn_dev.c: In function `phonet_device_get':
net/phonet/pn_dev.c:99: warning: 'dev' might be used uninitialized in this function

Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
---

diff --git a/net/phonet/pn_dev.c b/net/phonet/pn_dev.c
index b0d6ddd..c2b77a6 100644
--- a/net/phonet/pn_dev.c
+++ b/net/phonet/pn_dev.c
@@ -96,7 +96,7 @@ struct net_device *phonet_device_get(struct net *net)
 {
 	struct phonet_device_list *pndevs = phonet_device_list(net);
 	struct phonet_device *pnd;
-	struct net_device *dev;
+	struct net_device *dev = NULL;
 
 	spin_lock_bh(&pndevs->lock);
 	list_for_each_entry(pnd, &pndevs->list, list) {

Re: net-next-2.6 phonet causes build error

[Rémi Denis-Courmont]

On Monday 27 July 2009 10:03:06 ext Eric Dumazet wrote:
> Rémi Denis-Courmont a écrit :
> > On Sunday 26 July 2009 21:43:11 ext Oliver Hartkopp wrote:
> >> i got this build error from the latest net-next-2.6:
> >>
> >> net/phonet/pn_dev.c: In function ‘phonet_init_net’:
> >> net/phonet/pn_dev.c:221: error: implicit declaration of function
> >> ‘proc_net_fops_create’
> >> net/phonet/pn_dev.c: In function ‘phonet_exit_net’:
> >> net/phonet/pn_dev.c:242: error: implicit declaration of function
> >> ‘proc_net_remove’
> >
> > Oops. This makes me wonder why I did not get that one here on my test
> > builds???
>
> I also have this warning :
>
> net/phonet/pn_dev.c: In function `phonet_device_get':
> net/phonet/pn_dev.c:99: warning: 'dev' might be used uninitialized in this
> function

Right. This is indeed a bug - thanks. Either my gcc version is bad at that 
stuff or I have missing debug options :(

> What about following patch ?
>
> [PATCH] phonet: phonet_device_get() fix
>
> net/phonet/pn_dev.c: In function `phonet_device_get':
> net/phonet/pn_dev.c:99: warning: 'dev' might be used uninitialized in this
> function
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Acked-by: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>

> ---
>
> diff --git a/net/phonet/pn_dev.c b/net/phonet/pn_dev.c
> index b0d6ddd..c2b77a6 100644
> --- a/net/phonet/pn_dev.c
> +++ b/net/phonet/pn_dev.c
> @@ -96,7 +96,7 @@ struct net_device *phonet_device_get(struct net *net)
>  {
>  	struct phonet_device_list *pndevs = phonet_device_list(net);
>  	struct phonet_device *pnd;
> -	struct net_device *dev;
> +	struct net_device *dev = NULL;
>
>  	spin_lock_bh(&pndevs->lock);
>  	list_for_each_entry(pnd, &pndevs->list, list) {



-- 
Rémi Denis-Courmont
Nokia Devices R&D, Maemo Software, Helsinki

Re: net-next-2.6 phonet causes build error

[Eric Dumazet]

Rémi Denis-Courmont a écrit :
> On Monday 27 July 2009 10:03:06 ext Eric Dumazet wrote:
>> Rémi Denis-Courmont a écrit :
>>> On Sunday 26 July 2009 21:43:11 ext Oliver Hartkopp wrote:
>>>> i got this build error from the latest net-next-2.6:
>>>>
>>>> net/phonet/pn_dev.c: In function ‘phonet_init_net’:
>>>> net/phonet/pn_dev.c:221: error: implicit declaration of function
>>>> ‘proc_net_fops_create’
>>>> net/phonet/pn_dev.c: In function ‘phonet_exit_net’:
>>>> net/phonet/pn_dev.c:242: error: implicit declaration of function
>>>> ‘proc_net_remove’
>>> Oops. This makes me wonder why I did not get that one here on my test
>>> builds???
>> I also have this warning :
>>
>> net/phonet/pn_dev.c: In function `phonet_device_get':
>> net/phonet/pn_dev.c:99: warning: 'dev' might be used uninitialized in this
>> function
> 
> Right. This is indeed a bug - thanks. Either my gcc version is bad at that 
> stuff or I have missing debug options :(
> 

I currently use gcc-3.4.6, and current net-next-2.6 doesnt compile for me
(but linux-2.6 does compile properly so I just know this is already fixed upstream)

  UPD     include/linux/compile.h
  CC      init/version.o
  LD      init/built-in.o
  LD      .tmp_vmlinux1
drivers/built-in.o(.text+0x86b17): In function `igdng_compute_m_n':
: undefined reference to `__udivdi3'
drivers/built-in.o(.init.text+0x3c44): In function `con_init':
: undefined reference to `.L1443'
make: *** [.tmp_vmlinux1] Erreur 1

No problem with gcc-4.4.0 

Re: net-next-2.6 phonet causes build error

[David Miller]

From: Eric Dumazet <dada1@cosmosbay.com>
Date: Mon, 27 Jul 2009 10:09:24 +0200

> I currently use gcc-3.4.6, and current net-next-2.6 doesnt compile
> for me (but linux-2.6 does compile properly so I just know this is
> already fixed upstream)

Eric, just FYI, I am not going to merge Linus's tree into
net-2.6 (and therefore not into net-next-2.6 either) unless
there is some conflict to resolve.

So if you need this build fix, please integrate it locally
by whatever means works best for you.

Re: net-next-2.6 phonet causes build error

[Eric Dumazet]

David Miller a écrit :
> From: Eric Dumazet <dada1@cosmosbay.com>
> Date: Mon, 27 Jul 2009 10:09:24 +0200
> 
>> I currently use gcc-3.4.6, and current net-next-2.6 doesnt compile
>> for me (but linux-2.6 does compile properly so I just know this is
>> already fixed upstream)
> 
> Eric, just FYI, I am not going to merge Linus's tree into
> net-2.6 (and therefore not into net-next-2.6 either) unless
> there is some conflict to resolve.
> 
> So if you need this build fix, please integrate it locally
> by whatever means works best for you.

Thanks for the info David :)

Dont worry, I can deal with it !

Re: net-next-2.6 phonet causes build error

[David Miller]

From: "Rémi Denis-Courmont" <remi.denis-courmont@nokia.com>
Date: Mon, 27 Jul 2009 11:06:02 +0300

> On Monday 27 July 2009 10:03:06 ext Eric Dumazet wrote:
>>
>> [PATCH] phonet: phonet_device_get() fix
>>
>> net/phonet/pn_dev.c: In function `phonet_device_get':
>> net/phonet/pn_dev.c:99: warning: 'dev' might be used uninitialized in this
>> function
>>
>> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
> Acked-by: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>

Applied.

Re: net-next-2.6 phonet causes build error

[David Miller]

From: "Rémi Denis-Courmont" <remi.denis-courmont@nokia.com>
Date: Mon, 27 Jul 2009 09:27:55 +0300

> On Sunday 26 July 2009 21:43:11 ext Oliver Hartkopp wrote:
>> i got this build error from the latest net-next-2.6:
>>
>> net/phonet/pn_dev.c: In function ‘phonet_init_net’:
>> net/phonet/pn_dev.c:221: error: implicit declaration of function
>> ‘proc_net_fops_create’
>> net/phonet/pn_dev.c: In function ‘phonet_exit_net’:
>> net/phonet/pn_dev.c:242: error: implicit declaration of function
>> ‘proc_net_remove’
> 
> Oops. This makes me wonder why I did not get that one here on my test 
> builds???

Because the headers on your platform with your configuration end up
including linux/proc_fs.h indirectly.

Re: net-next-2.6 phonet causes build error

[Marcel Holtmann]

Hi Dave,

> >> net/phonet/pn_dev.c: In function ‘phonet_init_net’:
> >> net/phonet/pn_dev.c:221: error: implicit declaration of function
> >> ‘proc_net_fops_create’
> >> net/phonet/pn_dev.c: In function ‘phonet_exit_net’:
> >> net/phonet/pn_dev.c:242: error: implicit declaration of function
> >> ‘proc_net_remove’
> > 
> > Oops. This makes me wonder why I did not get that one here on my test 
> > builds???
> 
> Because the headers on your platform with your configuration end up
> including linux/proc_fs.h indirectly.

this and similar automatic includes on x86 are still a problem. I always
try to compile test with a PPC based system, but even that architecture
has a lot of indirect includes. I would be happy if we could get rid of
these for x86 systems, but that seems a little bit wishful thinking.

Regards

Marcel

Re: net-next-2.6 phonet causes build error

[David Miller]

From: Marcel Holtmann <marcel@holtmann.org>
Date: Mon, 27 Jul 2009 17:18:29 +0200

> Hi Dave,
> 
>> >> net/phonet/pn_dev.c: In function ‘phonet_init_net’:
>> >> net/phonet/pn_dev.c:221: error: implicit declaration of function
>> >> ‘proc_net_fops_create’
>> >> net/phonet/pn_dev.c: In function ‘phonet_exit_net’:
>> >> net/phonet/pn_dev.c:242: error: implicit declaration of function
>> >> ‘proc_net_remove’
>> > 
>> > Oops. This makes me wonder why I did not get that one here on my test 
>> > builds???
>> 
>> Because the headers on your platform with your configuration end up
>> including linux/proc_fs.h indirectly.
> 
> this and similar automatic includes on x86 are still a problem. I always
> try to compile test with a PPC based system, but even that architecture
> has a lot of indirect includes. I would be happy if we could get rid of
> these for x86 systems, but that seems a little bit wishful thinking.

I always do an allmodconfig build on sparc64 before pushing anything
out to my trees so I'm surprised I didn't hit this one.

Re: net-next-2.6 phonet causes build error

[Oliver Hartkopp]

Marcel Holtmann wrote:
> Hi Dave,
> 
>>>> net/phonet/pn_dev.c: In function ‘phonet_init_net’:
>>>> net/phonet/pn_dev.c:221: error: implicit declaration of function
>>>> ‘proc_net_fops_create’
>>>> net/phonet/pn_dev.c: In function ‘phonet_exit_net’:
>>>> net/phonet/pn_dev.c:242: error: implicit declaration of function
>>>> ‘proc_net_remove’
>>> Oops. This makes me wonder why I did not get that one here on my test 
>>> builds???
>> Because the headers on your platform with your configuration end up
>> including linux/proc_fs.h indirectly.
> 
> this and similar automatic includes on x86 are still a problem. I always
> try to compile test with a PPC based system, but even that architecture
> has a lot of indirect includes. I would be happy if we could get rid of
> these for x86 systems, but that seems a little bit wishful thinking.
> 

I second this. But in this special case i was using a x86 architecture, that
behaved correct.

Maybe one of the script wizards has an idea how to identify and /probably/ fix
these automatic includes ...

Regards,
Oliver