netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: mcuos.com@gmail.com
Cc: linux@arm.linux.org.uk, soni.trilok@gmail.com,
	netdev@vger.kernel.org, linux-arm-kernel@lists.arm.linux.org.uk,
	eric.y.miao@gmail.com
Subject: Re: [PATCH] Add mac driver for w90p910
Date: Mon, 27 Jul 2009 11:24:59 -0700 (PDT)	[thread overview]
Message-ID: <20090727.112459.224637019.davem@davemloft.net> (raw)
In-Reply-To: <4A67EC88.8010001@gmail.com>

From: Wan ZongShun <mcuos.com@gmail.com>
Date: Thu, 23 Jul 2009 12:52:24 +0800

> I fixed up previous mac driver and make a patch relative to it.

This patch does not apply to the code actually in the tree,
for example:

>  	ether->tdesc = (struct tran_pdesc *)
> -			dma_alloc_coherent(NULL, sizeof(struct tran_pdesc),
> -				(dma_addr_t *)&ether->tdesc_phys, GFP_KERNEL);
> +		dma_alloc_coherent(&pdev->dev, sizeof(struct tran_pdesc),
> +					&ether->tdesc_phys, GFP_KERNEL);
> +

in the tree there is a space between '(dma_addr_t *)' and
'&ether->tdesc_phys', but the code you are patching against
does not have that space.

Please do two things:

1) Generate your patch properly against the code actually in
   the tree.

2) Create a coherent, verbose, commit message and proper subject
   line which describes one-by-one the bug fixes you are making
   to the driver.

Thanks.

      reply	other threads:[~2009-07-27 18:24 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-16 12:55 [PATCH] Add mac driver for w90p910 Wan ZongShun
2009-07-16 17:42 ` Trilok Soni
2009-07-17 11:21   ` Wan ZongShun
2009-07-19 10:16     ` Russell King - ARM Linux
2009-07-20 14:45 ` David Miller
2009-07-20 17:49   ` Trilok Soni
2009-07-20 17:52     ` David Miller
2009-07-21  3:40       ` Wan ZongShun
2009-07-23  4:18       ` [PATCH] fixed up the previous " Wan ZongShun
2009-07-23  4:33         ` [PATCH] Add mac driver patch fixed " Wan ZongShun
2009-07-23  4:52       ` [PATCH] Add mac driver " Wan ZongShun
2009-07-27 18:24         ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090727.112459.224637019.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=eric.y.miao@gmail.com \
    --cc=linux-arm-kernel@lists.arm.linux.org.uk \
    --cc=linux@arm.linux.org.uk \
    --cc=mcuos.com@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=soni.trilok@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).