From: David Miller <davem@davemloft.net>
To: dhananjay.phadke@qlogic.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH NEXT 12/12] netxen: update version to 4.0.41
Date: Mon, 27 Jul 2009 12:38:07 -0700 (PDT) [thread overview]
Message-ID: <20090727.123807.268367807.davem@davemloft.net> (raw)
In-Reply-To: <7608421F3572AB4292BB2532AE89D56581877E22A4@AVEXMB1.qlogic.org>
From: Dhananjay Phadke <dhananjay.phadke@qlogic.com>
Date: Mon, 27 Jul 2009 12:26:58 -0700
> Ok, the idea for module params was to set global defaults
> (configured in modprobe.conf) vs. per interface ethtool calls.
> The ethtool support is anyway added by # 12 patch.
>
> Is it not good to have both options available?
No, it is not good.
With module parameters we:
1) duplicate functionality
2) every device driver will name the module parms differently,
therefore the interface for the user is different for every device
type
We discuss this all the time, and this is a pretty deep rooted
belief and requirement for all network drivers.
next prev parent reply other threads:[~2009-07-27 19:38 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-27 6:07 [PATCH NEXT 0/12] netxen: driver update Dhananjay Phadke
2009-07-27 6:07 ` [PATCH NEXT 01/12] netxen: refresh firmware info after reset Dhananjay Phadke
2009-07-27 17:33 ` David Miller
2009-07-27 6:07 ` [PATCH NEXT 02/12] netxen: enable ip addr hashing Dhananjay Phadke
2009-07-27 17:33 ` David Miller
2009-07-27 6:07 ` [PATCH NEXT 03/12] netxen: configure interrupt coalesce defaults Dhananjay Phadke
2009-07-27 17:33 ` David Miller
2009-07-27 6:07 ` [PATCH NEXT 04/12] netxen: annotate dma watchdog setup Dhananjay Phadke
2009-07-27 17:33 ` David Miller
2009-07-27 6:07 ` [PATCH NEXT 05/12] netxen: refactor tso code Dhananjay Phadke
2009-07-27 17:34 ` David Miller
2009-07-27 6:07 ` [PATCH NEXT 06/12] netxen: module params for ring sizes Dhananjay Phadke
2009-07-27 17:31 ` David Miller
2009-07-27 6:07 ` [PATCH NEXT 07/12] netxen: clean up frimware version checks Dhananjay Phadke
2009-07-27 17:38 ` David Miller
2009-07-27 6:07 ` [PATCH NEXT 08/12] netxen: refactor net_device setup code Dhananjay Phadke
2009-07-27 17:38 ` David Miller
2009-07-27 6:07 ` [PATCH NEXT 09/12] netxen: fix skb alloc size for legacy firmware Dhananjay Phadke
2009-07-27 17:38 ` David Miller
2009-07-27 6:07 ` [PATCH NEXT 10/12] netxen: add vlan tx acceleration support Dhananjay Phadke
2009-07-27 17:38 ` David Miller
2009-07-27 6:07 ` [PATCH NEXT 11/12] netxen: support for ethtool set ringparam Dhananjay Phadke
2009-07-27 17:38 ` David Miller
2009-07-27 6:07 ` [PATCH NEXT 12/12] netxen: update version to 4.0.41 Dhananjay Phadke
2009-07-27 17:38 ` David Miller
2009-07-27 17:54 ` David Miller
2009-07-27 19:26 ` Dhananjay Phadke
2009-07-27 19:38 ` David Miller [this message]
2009-07-27 21:51 ` Dhananjay Phadke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090727.123807.268367807.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dhananjay.phadke@qlogic.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).