From: Andi Kleen <andi@firstfloor.org>
To: David Miller <davem@davemloft.net>
Cc: andi@firstfloor.org, netdev@vger.kernel.org
Subject: Re: [PATCH] Add some function overview comments in tcp_input.c
Date: Mon, 27 Jul 2009 14:48:20 +0200 [thread overview]
Message-ID: <20090727124820.GA18785@basil.fritz.box> (raw)
In-Reply-To: <20090726.192321.257422911.davem@davemloft.net>
On Sun, Jul 26, 2009 at 07:23:21PM -0700, David Miller wrote:
> From: Andi Kleen <andi@firstfloor.org>
> Date: Fri, 24 Jul 2009 11:47:19 +0200
>
> > Add some function overview comments in tcp_input.c
> >
> > Only partial so far. I didn't attempt to accurately comment
> > the SACK machinery and the congestion state machine.
> >
> > I also fixed the grammar in one or two other comments
> > (but still trying to keep the authentic "ANK language" @)
> >
> > No code changes.
> >
> > Signed-off-by: Andi Kleen <ak@linux.intel.com>
>
> Most of your comments sound exactly the same as what I
> hear when I say the function's name out loud.
Ok, not all, but fair enough. Commenting existing code
was a folly anyways.
-Andi
prev parent reply other threads:[~2009-07-27 12:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-24 9:47 [PATCH] Add some function overview comments in tcp_input.c Andi Kleen
2009-07-27 2:23 ` David Miller
2009-07-27 12:48 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090727124820.GA18785@basil.fritz.box \
--to=andi@firstfloor.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).