From: Jarek Poplawski <jarkao2@gmail.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: David Miller <davem@davemloft.net>,
krkumar2@in.ibm.com, netdev@vger.kernel.org
Subject: Re: [RFC] [PATCH] Don't run __qdisc_run() on a stopped TX queue
Date: Tue, 28 Jul 2009 09:02:29 +0000 [thread overview]
Message-ID: <20090728090229.GA6593@ff.dom.local> (raw)
In-Reply-To: <20090728084451.GA26299@gondor.apana.org.au>
On Tue, Jul 28, 2009 at 04:44:51PM +0800, Herbert Xu wrote:
> On Tue, Jul 28, 2009 at 08:37:13AM +0000, Jarek Poplawski wrote:
> >
> > Hmm.. would something IMHO_more_readable/less_fixing like:
> > (qdisc->flags & TCQ_F_DEFAULT) be too much? (Btw, IIRC there was an
> > idea long time ago to treat all queues equally.)
>
> Well the fact that as it stands the only true multiqueue qdisc
> is the default is a mere coincidence. There is no fundamental
> reason why non-default qdiscs cannot be made multiqueue aware,
> well, for some of them anyway.
>
> For example, sfq can naturally be enhanced as a multiqueue qdisc
> just like the default qdisc.
>
> So I don't think we want to prejudice what a future non-default
> qdisc may support.
If it's only about the name I'm OK with: (qdisc->flags &
TCQ_F_DEFAULT_WITHOUT_PREJUDICE_MAYBE_NON_DEFAULT_IN_THE_FUTURE)
or any other, too ;-)
Cheers,
Jarek P.
next prev parent reply other threads:[~2009-07-28 9:02 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-20 7:46 [RFC] [PATCH] Don't run __qdisc_run() on a stopped TX queue Krishna Kumar
2009-07-24 8:30 ` Jarek Poplawski
2009-07-24 8:37 ` Herbert Xu
2009-07-24 10:31 ` Krishna Kumar2
2009-07-25 3:24 ` Herbert Xu
2009-07-25 11:04 ` Jarek Poplawski
2009-07-25 11:12 ` Herbert Xu
2009-07-25 11:53 ` Jarek Poplawski
2009-07-28 2:28 ` David Miller
2009-07-28 2:48 ` Herbert Xu
2009-07-28 4:21 ` David Miller
2009-07-28 6:43 ` Jarek Poplawski
2009-07-28 8:03 ` Herbert Xu
2009-07-28 8:37 ` Jarek Poplawski
2009-07-28 8:44 ` Herbert Xu
2009-07-28 9:02 ` Jarek Poplawski [this message]
2009-07-28 10:53 ` Herbert Xu
2009-07-28 11:24 ` Jarek Poplawski
2009-07-28 11:43 ` Krishna Kumar2
2009-07-28 11:48 ` Herbert Xu
2009-07-28 12:24 ` Krishna Kumar2
2009-07-28 20:02 ` David Miller
2009-07-28 7:12 ` Herbert Xu
2009-07-28 19:59 ` David Miller
2009-07-29 0:44 ` Herbert Xu
2009-07-29 1:06 ` David Miller
2009-07-29 1:25 ` Herbert Xu
2009-07-29 1:34 ` David Miller
2009-07-29 2:12 ` Herbert Xu
2009-07-29 2:22 ` David Miller
2009-07-29 2:38 ` Herbert Xu
2009-07-29 3:15 ` Herbert Xu
2009-08-04 3:15 ` David Miller
2009-07-29 11:04 ` Jarek Poplawski
2009-07-29 11:11 ` Herbert Xu
2009-07-29 11:26 ` Jarek Poplawski
2009-07-29 12:30 ` Herbert Xu
2009-07-29 12:47 ` Jarek Poplawski
2009-07-29 13:08 ` Krishna Kumar2
2009-07-29 19:26 ` Jarek Poplawski
2009-07-29 13:28 ` Krishna Kumar2
2009-07-24 12:46 ` Eric Dumazet
2009-07-24 14:54 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090728090229.GA6593@ff.dom.local \
--to=jarkao2@gmail.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=krkumar2@in.ibm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).