From: David Miller <davem@davemloft.net>
To: michaelc@cs.wisc.edu
Cc: open-iscsi@googlegroups.com,
James.Bottomley@HansenPartnership.com, netdev@vger.kernel.org,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] iscsi: Use GFP_ATOMIC in iscsi_offload_mesg().
Date: Thu, 30 Jul 2009 11:04:18 -0700 (PDT) [thread overview]
Message-ID: <20090730.110418.14002042.davem@davemloft.net> (raw)
In-Reply-To: <4A70FA22.7010706@cs.wisc.edu>
From: Mike Christie <michaelc@cs.wisc.edu>
Date: Wed, 29 Jul 2009 20:40:50 -0500
> On 07/29/2009 01:49 PM, Michael Chan wrote:
>> Changing to GFP_ATOMIC because the only caller in cnic/bnx2i may
>> be calling this function while holding spin_lock.
>>
>> This problem was discovered by Mike Christie.
>>
>> Signed-off-by: Michael Chan<mchan@broadcom.com>
...
> Acked-by: Mike Christie <michaelc@cs.wisc.edu>
>
> Dave Miller probably wants to take this in his tree since it fixes a
> bug with this patch
> http://git.kernel.org/?p=linux/kernel/git/davem/net-2.6.git;a=commit;h=6d7760a88c25057c2c2243e5dfe2d731064bd31d
Yep I'll take it, thanks everyone.
next prev parent reply other threads:[~2009-07-30 18:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-23 3:01 [PATCH] cnic: Fix ISCSI_KEVENT_IF_DOWN message handling Michael Chan
2009-07-27 18:26 ` David Miller
2009-07-29 7:50 ` Mike Christie
2009-07-29 7:55 ` Michael Chan
2009-07-29 8:17 ` Mike Christie
[not found] ` <4A70058F.50403-hcNo3dDEHLuVc3sceRu5cw@public.gmane.org>
2009-07-29 18:49 ` [PATCH] iscsi: Use GFP_ATOMIC in iscsi_offload_mesg() Michael Chan
2009-07-30 1:40 ` Mike Christie
2009-07-30 18:04 ` David Miller [this message]
2009-07-29 8:42 ` [PATCH] cnic: Fix ISCSI_KEVENT_IF_DOWN message handling Anil Veerabhadrappa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090730.110418.14002042.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=James.Bottomley@HansenPartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
--cc=netdev@vger.kernel.org \
--cc=open-iscsi@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).