From: David Miller <davem@davemloft.net>
To: jarkao2@gmail.com
Cc: roel.kluin@gmail.com, netdev@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [PATCH] eexpress: Read buffer overflow
Date: Thu, 30 Jul 2009 13:28:25 -0700 (PDT) [thread overview]
Message-ID: <20090730.132825.03094033.davem@davemloft.net> (raw)
In-Reply-To: <20090729200517.GB3058@ami.dom.local>
From: Jarek Poplawski <jarkao2@gmail.com>
Date: Wed, 29 Jul 2009 22:05:17 +0200
> On Wed, Jul 29, 2009 at 03:18:56PM +0200, Roel Kluin wrote:
>> start_code is 69 words, but the code always writes a multiple of 16 words,
>> so the last 11 words written are outside the array.
>>
>> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
>> ---
>> > Now you seem to make my previous math working :-)
>> >
>> >>> (max) i = 64, (max) j = 14, (64+14+16)/2 = 47 < 69, so it seems to copy
>> >>> less than its size?
>> >
>> > Jarek P.
>> >
>>
>> You're right, thanks for reviewing, this one should be correct.
>
> Looks OK to me.
Applied.
prev parent reply other threads:[~2009-07-30 20:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-25 19:50 [PATCH] eexpress: Read buffer overflow Roel Kluin
2009-07-26 20:16 ` Jarek Poplawski
2009-07-26 21:47 ` Jarek Poplawski
2009-07-27 1:45 ` David Miller
2009-07-29 12:15 ` Roel Kluin
2009-07-29 12:29 ` Jarek Poplawski
2009-07-29 13:18 ` Roel Kluin
2009-07-29 20:05 ` Jarek Poplawski
2009-07-30 20:28 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090730.132825.03094033.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=jarkao2@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).