netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger@vyatta.com>
To: Jay Vosburgh <fubar@us.ibm.com>
Cc: Ben Greear <greearb@candelatech.com>,
	bonding-devel@lists.sf.net, netdev@vger.kernel.org
Subject: Re: Bonding ALB sends bogus packets
Date: Thu, 30 Jul 2009 13:35:45 -0700	[thread overview]
Message-ID: <20090730133545.77e5a76a@nehalam> (raw)
In-Reply-To: <22132.1248985699@death.nxdomain.ibm.com>

On Thu, 30 Jul 2009 13:28:19 -0700
Jay Vosburgh <fubar@us.ibm.com> wrote:

> Stephen Hemminger <shemminger@vyatta.com> wrote:
> 
> >The bonding ALB mode builds packets with type, ETH_P_LOOP.
> >
> >Well ETH_P_LOOP is defined as 0x0060 which looks completely bogus.
> >All Ethernet types less than 1536 are interpreted as 802.2 frames.
> >The result is that the resulting packet looks like a bogus 802.2
> >frame to the other host (or switch).  I have no idea what the 
> >initial design was or what the purpose of this code is, but it
> >should either send a real packet or nothing at all.
> 
> 	I've looked at that code before, too, although I hadn't noticed
> that ETH_P_LOOP is under the limit for interpretation as a length
> instead of a type.
> 
> 	I believe the purpose of the code is to update the switch's MAC
> address table for the port and insure it's correct, since the alb mode
> can move MAC addresses around amongst the set of slaves.
> 
> 	-J

Then it ought to send an ARP or at least a real-looking 802.2 packet.
Also, if the purpose was to update switch MAC table, why does it need
to do it so often, rather than only when MAC address is swapped.

  reply	other threads:[~2009-07-30 20:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-30 20:06 Bonding ALB sends bogus packets Stephen Hemminger
2009-07-30 20:28 ` Jay Vosburgh
2009-07-30 20:35   ` Stephen Hemminger [this message]
2009-07-30 23:36     ` Mark Smith
2009-07-30 23:48       ` Rick Jones
2009-07-31  1:30         ` Mark Smith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090730133545.77e5a76a@nehalam \
    --to=shemminger@vyatta.com \
    --cc=bonding-devel@lists.sf.net \
    --cc=fubar@us.ibm.com \
    --cc=greearb@candelatech.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).