[PATCH 0/4] au1000_eth platform device/driver conversion

[PATCH 0/4] au1000_eth platform device/driver conversion

[Florian Fainelli]

Hi Ralf, David, Manuel,

The following patches convert the AMD Alchemy au1000_eth driver
to become a platform device/driver. The patches are splitted that way:

PATCH 1: set up the infrastructure in the board code to register au1000_eth as
as platform device.
PATCH 2: convert au1000_eth to become a real platform driver
PATCH 3: add infrastructure to pass PHY informations to the au1000_eth driver
PATCH 4: use those platform_data PHY informations in the au1000_eth driver

The result is a driver which is equally functionnal with no platform-related ifdefs
aiming towards easier integration of the upcoming Alchemy 1300 SoC. The conversion
was made in two times to ease code review as the driver was a real ifdef mess prior
to these changes.

David, on top of this series I send driver cleanups.

Thanks !
-- 
Best regards, Florian Fainelli
Email: florian@openwrt.org
Web: http://openwrt.org
IRC: [florian] on irc.freenode.net
-------------------------------

Re: [PATCH 0/4] au1000_eth platform device/driver conversion

[David Miller]

From: Florian Fainelli <florian@openwrt.org>
Date: Tue, 28 Jul 2009 23:00:04 +0200

> Hi Ralf, David, Manuel,
> 
> The following patches convert the AMD Alchemy au1000_eth driver
> to become a platform device/driver. The patches are splitted that way:

I was only able to see patch #2 and #4 in this series and
checking the netdev patch postings that made it to:

	http://patchwork.ozlabs.org/project/netdev/list/

confirms that patches #1 and #3 didn't make it to the list
either.

Re: [PATCH 0/4] au1000_eth platform device/driver conversion

[Sergei Shtylyov]

Hello.

David Miller wrote:

> From: Florian Fainelli <florian@openwrt.org>
> Date: Tue, 28 Jul 2009 23:00:04 +0200
>   
>> Hi Ralf, David, Manuel,
>>
>> The following patches convert the AMD Alchemy au1000_eth driver
>> to become a platform device/driver. The patches are splitted that way:
>>     
>
> I was only able to see patch #2 and #4 in this series and
> checking the netdev patch postings that made it to:
>
> 	http://patchwork.ozlabs.org/project/netdev/list/
>
> confirms that patches #1 and #3 didn't make it to the list
> either.

   Because they were only posted to linux-mips. And we didn't see #2 and 
#4 in linux-mips either.

WBR, Sergei

Re: [PATCH 0/4] au1000_eth platform device/driver conversion

[David Miller]

From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Date: Thu, 30 Jul 2009 23:48:13 +0400

>   Because they were only posted to linux-mips. And we didn't see #2 and
>   #4 in linux-mips either.

That's not going to work.

You can't apply some of these patches to one tree, and some to
the other.  That leaves the driver in a half-baked state in BOTH
trees during the entire development period.

So one of the two trees has to be chosen and all 4 patches added
there, and there only.

Re: [PATCH 0/4] au1000_eth platform device/driver conversion

[Florian Fainelli]

Hi,

Le Thursday 30 July 2009 22:10:00 David Miller, vous avez écrit :
> From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
> Date: Thu, 30 Jul 2009 23:48:13 +0400
>
> >   Because they were only posted to linux-mips. And we didn't see #2 and
> >   #4 in linux-mips either.
>
> That's not going to work.
>
> You can't apply some of these patches to one tree, and some to
> the other.  That leaves the driver in a half-baked state in BOTH
> trees during the entire development period.

Sorry about that I did not want to "spam" netdev with MIPS specific bits as I 
know those specific changes would lead to a discussion for sure.

>
> So one of the two trees has to be chosen and all 4 patches added
> there, and there only.

Ok, I got to respin them to address some comments on the MIPS-side anyway and 
will not forget to CC netdev and you this time.
-- 
Best regards, Florian Fainelli
Email: florian@openwrt.org
Web: http://openwrt.org
IRC: [florian] on irc.freenode.net
-------------------------------

Re: [PATCH 0/4] au1000_eth platform device/driver conversion

[David Miller]

From: Florian Fainelli <florian@openwrt.org>
Date: Thu, 30 Jul 2009 22:13:59 +0200

> Ok, I got to respin them to address some comments on the MIPS-side
> anyway and will not forget to CC netdev and you this time.

Thank you.