From: David Miller <davem@davemloft.net>
To: jpirko@redhat.com
Cc: netdev@vger.kernel.org, mroos@linux.ee, eric.dumazet@gmail.com
Subject: Re: [PATCH net-2.6] net: restore the original spinlock to protect unicast list
Date: Sun, 02 Aug 2009 12:29:27 -0700 (PDT) [thread overview]
Message-ID: <20090802.122927.17579898.davem@davemloft.net> (raw)
In-Reply-To: <20090730110612.GD3686@psychotron.englab.brq.redhat.com>
From: Jiri Pirko <jpirko@redhat.com>
Date: Thu, 30 Jul 2009 13:06:12 +0200
> There is a path when an assetion in dev_unicast_sync() appears.
>
> igmp6_group_added -> dev_mc_add -> __dev_set_rx_mode ->
> -> vlan_dev_set_rx_mode -> dev_unicast_sync
>
> Therefore we cannot protect this list with rtnl. This patch restores the
> original protecting this list with spinlock.
>
> Signed-off-by: Jiri Pirko <jpirko@redhat.com>
Applied, thanks.
prev parent reply other threads:[~2009-08-02 19:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-30 8:23 RTNL: assertion failed at net/core/dev.c (3961) Meelis Roos
2009-07-30 9:08 ` Eric Dumazet
2009-07-30 10:08 ` Jiri Pirko
2009-07-30 11:06 ` [PATCH net-2.6] net: restore the original spinlock to protect unicast list Jiri Pirko
2009-07-30 12:38 ` Meelis Roos
2009-08-02 19:29 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090802.122927.17579898.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=jpirko@redhat.com \
--cc=mroos@linux.ee \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).