From: David Miller <davem@davemloft.net>
To: bzolnier@gmail.com
Cc: pcnet32@verizon.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, error27@gmail.com, corbet@lwn.net,
eteo@redhat.com, julia@diku.dk
Subject: Re: [PATCH] pcnet32: VLB support fixes
Date: Sun, 02 Aug 2009 12:30:33 -0700 (PDT) [thread overview]
Message-ID: <20090802.123033.168343935.davem@davemloft.net> (raw)
In-Reply-To: <200907302317.52648.bzolnier@gmail.com>
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Date: Thu, 30 Jul 2009 23:17:52 +0200
> From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> Subject: [PATCH] pcnet32: VLB support fixes
>
> VLB support has been broken since at least 2004-2005 period as some
> changes introduced back then assumed that ->pci_dev is always valid,
> lets try to fix it:
>
> - remove duplicated SET_NETDEV_DEV() call
>
> - call SET_NETDEV_DEV() only for PCI devices
>
> - check for ->pci_dev validity in pcnet32_open()
>
> [ Alternatively we may consider removing VLB support but there would not
> be much gain in it since an extra driver code needed for VLB support is
> minimal and quite simple. ]
>
> This takes care of the following entry from Dan's list:
>
> drivers/net/pcnet32.c +1889 pcnet32_probe1(298) warning: variable derefenced before check 'pdev'
>
> Reported-by: Dan Carpenter <error27@gmail.com>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Also applied, thanks.
prev parent reply other threads:[~2009-08-02 19:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-30 21:17 [PATCH] pcnet32: VLB support fixes Bartlomiej Zolnierkiewicz
2009-07-30 21:32 ` Jeff Garzik
2009-07-30 21:46 ` Bartlomiej Zolnierkiewicz
2009-07-30 21:58 ` Jeff Garzik
2009-07-30 22:25 ` Bartlomiej Zolnierkiewicz
2009-07-31 18:45 ` Don Fry
2009-08-02 19:30 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090802.123033.168343935.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bzolnier@gmail.com \
--cc=corbet@lwn.net \
--cc=error27@gmail.com \
--cc=eteo@redhat.com \
--cc=julia@diku.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pcnet32@verizon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).