From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: luciano.coelho@nokia.com, netdev@vger.kernel.org, tero.kristo@nokia.com
Subject: Re: neigh_periodic_timer expires too often
Date: Sun, 02 Aug 2009 18:35:53 -0700 (PDT) [thread overview]
Message-ID: <20090802.183553.257296569.davem@davemloft.net> (raw)
In-Reply-To: <4A719CDB.3060004@gmail.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 30 Jul 2009 15:15:07 +0200
> [PATCH net-next-2.6] neigh: Convert garbage collection from softirq to workqueue
>
> Current neigh_periodic_timer() function is fired by timer IRQ, and
> scans one hash bucket each round (very litle work in fact)
>
> As we are supposed to scan whole hash table in 15 seconds, this means
> neigh_periodic_timer() can be fired very often. (depending on the number
> of concurrent hash entries we stored in this table)
>
> Converting this to a workqueue permits scanning whole table, minimizing
> icache pollution, and firing this work every 15 seconds, independantly
> of hash table size.
>
> This 15 seconds delay is not a hard number, as work is a deferrable one.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied to net-next-2.6, thanks!
prev parent reply other threads:[~2009-08-03 1:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-30 10:44 neigh_periodic_timer expires too often Luciano Coelho
2009-07-30 13:15 ` Eric Dumazet
2009-07-30 14:33 ` Luciano Coelho
2009-07-31 12:22 ` Luciano Coelho
2009-07-31 12:50 ` Eric Dumazet
2009-08-05 7:48 ` Luciano Coelho
2009-08-03 1:35 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090802.183553.257296569.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=luciano.coelho@nokia.com \
--cc=netdev@vger.kernel.org \
--cc=tero.kristo@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).