From: David Miller <davem@davemloft.net>
To: jie.yang@atheros.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: atl1c: Do not call cancel_work_sync from the work itself
Date: Mon, 03 Aug 2009 13:20:49 -0700 (PDT) [thread overview]
Message-ID: <20090803.132049.77191266.davem@davemloft.net> (raw)
In-Reply-To: <12492775393830-git-send-email-jie.yang@atheros.com>
From: <jie.yang@atheros.com>
Date: Mon, 3 Aug 2009 13:32:19 +0800
> Signed-off-by: jie yang <jie.yang>@atheros.com
Your entire email address should be surrounded by '<' and '>'
characters, not just your username, in the signoff.
Also, please provide a more detailed commit message. Explain what
goes wrong in the current code (when happens when a work is cancelled
within itself, I was under the impression that this works just fine
and is just a NOP), and the basic description of your solution.
prev parent reply other threads:[~2009-08-03 20:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-03 5:32 atl1c: Do not call cancel_work_sync from the work itself jie.yang
2009-08-03 20:20 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090803.132049.77191266.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jie.yang@atheros.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox