From: David Miller <davem@davemloft.net>
To: paul.moore@hp.com
Cc: netdev@vger.kernel.org
Subject: Re: [RFC PATCH v1] tun: Cleanup error handling in tun_set_iff()
Date: Mon, 03 Aug 2009 21:16:39 -0700 (PDT) [thread overview]
Message-ID: <20090803.211639.93476997.davem@davemloft.net> (raw)
In-Reply-To: <20090803161242.12947.14620.stgit@flek.lan>
From: Paul Moore <paul.moore@hp.com>
Date: Mon, 03 Aug 2009 12:12:43 -0400
> Convert some pointless gotos into returns and ensure tun_attach() errors are
> handled correctly.
>
> Signed-off-by: Paul Moore <paul.moore@hp.com>
>
> --
>
> I'm sending this as an RFC patch because I'm not entirely certain that the
> changes to the tun_attach() error handling code are 100% correct, although I
> strongly suspect that the current behavor of simply returning an error code
> without any cleanup is broken. Can anyone comment on this?
It looks good to me.
But I've been wrong about this code before, so it would be nice
to get some other eyes on it :-)
next prev parent reply other threads:[~2009-08-04 4:16 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-03 16:12 [RFC PATCH v1] tun: Cleanup error handling in tun_set_iff() Paul Moore
2009-08-04 4:16 ` David Miller [this message]
2009-08-05 5:32 ` Eric W. Biederman
2009-08-05 21:38 ` Paul Moore
2009-08-05 23:14 ` Eric W. Biederman
2009-08-06 18:20 ` Paul Moore
2009-08-07 0:00 ` Herbert Xu
2009-08-07 12:23 ` Paul Moore
2009-08-06 10:10 ` Herbert Xu
2009-08-06 10:21 ` Eric W. Biederman
2009-08-06 13:37 ` Herbert Xu
2009-08-06 14:27 ` Eric W. Biederman
2009-08-06 14:39 ` Herbert Xu
2009-08-06 15:02 ` Eric W. Biederman
2009-08-06 18:09 ` Paul Moore
2009-08-06 18:41 ` David Miller
2009-08-07 0:22 ` Herbert Xu
2009-08-07 3:40 ` David Miller
2009-08-07 4:22 ` Eric W. Biederman
2009-08-10 4:52 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090803.211639.93476997.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=paul.moore@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).