From: David Miller <davem@davemloft.net>
To: chiachi@android.com
Cc: john.dykstra1@gmail.com, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] net: Keep interface binding when sending packets with ipi_ifindex = 0
Date: Tue, 04 Aug 2009 11:57:01 -0700 (PDT) [thread overview]
Message-ID: <20090804.115701.250978139.davem@davemloft.net> (raw)
In-Reply-To: <6c039e090908040036j38666152y2db1d4c55529eaff@mail.gmail.com>
From: Chia-chi Yeh (葉家齊) <chiachi@android.com>
Date: Tue, 4 Aug 2009 15:36:46 +0800
> After thinking more deeply, I believe that IPv6 does the right thing
> and IPv4 does not. SO_BINDTODEVICE requires CAP_NET_RAW, so it is a
> privileged operation. Therefore, it looks weird to me if one can
> specify other interface than the bound one without the same
> capability. The following patch makes the behavior in IPv4 and IPv6
> identical. Thanks for your help.
I think we really cannot change behavior here. If the user specifies
"0" in ipi_ifindex we must respect that in ipc->oif. This is an
override, and the ability to override is the very purpose of this
control message.
Even GLIBC makes use of that case of specifying "0" in ipi_ifindex.
We must respect it.
I'm not applying any of these patches, sorry.
next prev parent reply other threads:[~2009-08-04 18:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <6c039e090907231439t1def08a4n10978733bee55bec@mail.gmail.com>
2009-07-27 21:44 ` [PATCH] net: Keep interface binding when sending packets with ipi_ifindex = 0 Andrew Morton
2009-07-30 0:10 ` John Dykstra
2009-08-04 4:23 ` David Miller
2009-08-04 7:36 ` Chia-chi Yeh (葉家齊)
2009-08-04 7:57 ` Badalian Vyacheslav
2009-08-04 8:28 ` Chia-chi Yeh (葉家齊)
2009-08-04 18:57 ` David Miller [this message]
2009-08-05 0:06 ` Chia-chi Yeh (葉家齊)
2009-08-05 2:33 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090804.115701.250978139.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=chiachi@android.com \
--cc=john.dykstra1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).