netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 4/5] cpmac: wait longer after MDIO reset
@ 2009-08-04 20:52 Florian Fainelli
  2009-08-05 19:23 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Florian Fainelli @ 2009-08-04 20:52 UTC (permalink / raw)
  To: Ralf Baechle; +Cc: linux-mips, netdev, David Miller

This patch slows down the MDIO_ALIVE busy waiting to let
switches and PHY come up after reset. Previous loop was
too quick for IC+175C and ADM6996C/L switches to come up.

Signed-off-by: Florian Fainelli <florian@openwrt.org>
---
diff --git a/drivers/net/cpmac.c b/drivers/net/cpmac.c
index f2fc722..12a521e 100644
--- a/drivers/net/cpmac.c
+++ b/drivers/net/cpmac.c
@@ -1245,11 +1245,11 @@ int __devinit cpmac_init(void)
 
 	cpmac_mii->reset(cpmac_mii);
 
-	for (i = 0; i < 300000; i++)
+	for (i = 0; i < 300; i++)
 		if ((mask = cpmac_read(cpmac_mii->priv, CPMAC_MDIO_ALIVE)))
 			break;
 		else
-			cpu_relax();
+			msleep(10);
 
 	mask &= 0x7fffffff;
 	if (mask & (mask - 1)) {

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 4/5] cpmac: wait longer after MDIO reset
  2009-08-04 20:52 [PATCH 4/5] cpmac: wait longer after MDIO reset Florian Fainelli
@ 2009-08-05 19:23 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2009-08-05 19:23 UTC (permalink / raw)
  To: florian; +Cc: ralf, linux-mips, netdev

From: Florian Fainelli <florian@openwrt.org>
Date: Tue, 4 Aug 2009 22:52:57 +0200

> This patch slows down the MDIO_ALIVE busy waiting to let
> switches and PHY come up after reset. Previous loop was
> too quick for IC+175C and ADM6996C/L switches to come up.
> 
> Signed-off-by: Florian Fainelli <florian@openwrt.org>

Applied to net-next-2.6

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-08-05 19:23 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-08-04 20:52 [PATCH 4/5] cpmac: wait longer after MDIO reset Florian Fainelli
2009-08-05 19:23 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).