From: David Miller <davem@davemloft.net>
To: dbaryshkov@gmail.com
Cc: netdev@vger.kernel.org, slapin@ossfans.org,
linux-zigbee-devel@lists.sourceforge.net
Subject: Re: [PATCH 2/3] af_ieee802154: provide dummy get/setsockopt
Date: Wed, 05 Aug 2009 20:19:37 -0700 (PDT) [thread overview]
Message-ID: <20090805.201937.242694288.davem@davemloft.net> (raw)
In-Reply-To: <20090805214139.GA6553@doriath.ww600.siemens.net>
From: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
Date: Thu, 6 Aug 2009 01:41:39 +0400
> On Wed, Aug 05, 2009 at 12:17:14PM -0700, David Miller wrote:
>> From: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
>> Date: Wed, 5 Aug 2009 11:28:16 +0400
>>
>> > Provide dummt get/setsockopt implementations to stop these
>> > syscalls from oopsing on our sockets.
>> >
>> > Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
>>
>> See "sock_no_getsockopt()" and "sock_no_setsockopt()" which are
>> provided specifically for this situation.
>
> There functions are to be used in struct proto_ops and not in the
> struct proto. I'd like to use sock_common_get/setsockopt() from the
> beginning, as there will be sockopts at least for dgram protocols.
Ok, my bad. The patch is fine.
prev parent reply other threads:[~2009-08-06 3:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-05 7:28 [GIT PULL 0/3] IEEE 802.15.4 last-minute fixes v2 Dmitry Eremin-Solenikov
2009-08-05 7:28 ` [PATCH 1/3] af_ieee802154: fix ioctl processing Dmitry Eremin-Solenikov
2009-08-05 7:28 ` [PATCH 2/3] af_ieee802154: provide dummy get/setsockopt Dmitry Eremin-Solenikov
2009-08-05 7:28 ` [PATCH 3/3] documentation: fix wrt. headers rename Dmitry Eremin-Solenikov
2009-08-06 3:22 ` David Miller
2009-08-06 9:26 ` Dmitry Eremin-Solenikov
2009-08-06 17:34 ` David Miller
2009-08-05 19:17 ` [PATCH 2/3] af_ieee802154: provide dummy get/setsockopt David Miller
[not found] ` <20090805.121714.182898812.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2009-08-05 21:41 ` Dmitry Eremin-Solenikov
2009-08-06 3:19 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090805.201937.242694288.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dbaryshkov@gmail.com \
--cc=linux-zigbee-devel@lists.sourceforge.net \
--cc=netdev@vger.kernel.org \
--cc=slapin@ossfans.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).