From: David Miller <davem@davemloft.net>
To: krkumar2@in.ibm.com
Cc: herbert@gondor.apana.org.au, jarkao2@gmail.com, kaber@trash.net,
netdev@vger.kernel.org
Subject: Re: [PATCH ver2] Avoid enqueuing skb for default qdiscs
Date: Thu, 06 Aug 2009 20:08:57 -0700 (PDT) [thread overview]
Message-ID: <20090806.200857.172982468.davem@davemloft.net> (raw)
In-Reply-To: <OF41857EFE.FD813620-ON6525760B.000F5D7C-6525760B.00101EC7@in.ibm.com>
From: Krishna Kumar2 <krkumar2@in.ibm.com>
Date: Fri, 7 Aug 2009 08:26:04 +0530
> David Miller <davem@davemloft.net> wrote on 08/07/2009 02:11:26 AM:
>
>> I'm dubious about this new qlen accounting scheme, does it handle
>> the non-bypass case properly? Can you explain how it works
>> exactly?
>
> Adding one to qlen will handle non-bypass correctly. On the next
> non-bypass (or a bypass) xmit, dequeue_skb will remove gso_skb and
> decrement the counter. If no more xmits are done, qdisc_reset will
> also fix it. I got this idea by extending one of Jarek's patches:
Aha, I see. Thanks for the explanation.
Ok, I'll let this rip... let's see what falls out of it :-)
Will apply this to net-next-2.6 right now.
next prev parent reply other threads:[~2009-08-07 3:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-06 11:44 [PATCH ver2] Avoid enqueuing skb for default qdiscs Krishna Kumar
2009-08-06 20:41 ` David Miller
2009-08-07 2:56 ` Krishna Kumar2
2009-08-07 3:08 ` David Miller [this message]
2009-08-06 20:49 ` Stephen Hemminger
2009-08-07 3:01 ` Krishna Kumar2
2010-02-01 9:52 ` Maxime Bizon
2010-02-01 13:42 ` Krishna Kumar2
2010-02-01 14:16 ` Maxime Bizon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090806.200857.172982468.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jarkao2@gmail.com \
--cc=kaber@trash.net \
--cc=krkumar2@in.ibm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).