From: Steffen Klassert <klassert@mathematik.tu-chemnitz.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>, netdev@vger.kernel.org
Subject: Re: 3x59x-fix-pci-resource-management.patch
Date: Fri, 7 Aug 2009 12:01:36 +0200 [thread overview]
Message-ID: <20090807100136.GB12932@skl-net.de> (raw)
In-Reply-To: <20090806154223.b9b9759e.akpm@linux-foundation.org>
On Thu, Aug 06, 2009 at 03:42:23PM -0700, Andrew Morton wrote:
> /* PCI-only startup logic */
> if (pdev) {
> - /* EISA resources already marked, so only PCI needs to do this here */
> - /* Ignore return value, because Cardbus drivers already allocate for us */
> - if (request_region(dev->base_addr, vci->io_size, print_name) != NULL)
> - vp->must_free_region = 1;
> -
I don't know what cardbus does, but __request_region() returns NULL on
memory allocation failure for struct resource too. So this did not work
in all cases anyway. If cardbus allocates for us, we should handle it in
some way, if not I'm fine with the patch as it is.
next prev parent reply other threads:[~2009-08-07 10:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-06 22:42 3x59x-fix-pci-resource-management.patch Andrew Morton
2009-08-07 8:19 ` 3x59x-fix-pci-resource-management.patch Steffen Klassert
2009-08-07 8:33 ` 3x59x-fix-pci-resource-management.patch Andrew Morton
2009-08-07 10:01 ` Steffen Klassert [this message]
2009-08-07 10:53 ` 3x59x-fix-pci-resource-management.patch Sergei Shtylyov
2009-08-07 16:14 ` 3x59x-fix-pci-resource-management.patch Andrew Morton
2009-08-13 0:26 ` 3x59x-fix-pci-resource-management.patch David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090807100136.GB12932@skl-net.de \
--to=klassert@mathematik.tu-chemnitz.de \
--cc=akpm@linux-foundation.org \
--cc=netdev@vger.kernel.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).