From: Neil Horman <nhorman@tuxdriver.com>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, rostedt@goodmis.org
Subject: Re: [PATCH 1/3] net: Add ftracer to help optimize process scheduling based on incomming frame allocations (v2)
Date: Sat, 8 Aug 2009 19:14:34 -0400 [thread overview]
Message-ID: <20090808231434.GB24414@localhost.localdomain> (raw)
In-Reply-To: <20090808231322.GA24414@localhost.localdomain>
skb allocation / cosumption tracer - Add consumption tracepoint
This patch adds a tracepoint to skb_copy_datagram_iovec, which is called each
time a userspace process copies a frame from a socket receive queue to a user
space buffer. It allows us to hook in and examine each sk_buff that the system
receives on a per-socket bases, and can be use to compile a list of which skb's
were received by which processes.
Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
include/trace/events/skb.h | 20 ++++++++++++++++++++
net/core/datagram.c | 3 +++
2 files changed, 23 insertions(+)
diff --git a/include/trace/events/skb.h b/include/trace/events/skb.h
index 1e8fabb..bdc5c1c 100644
--- a/include/trace/events/skb.h
+++ b/include/trace/events/skb.h
@@ -2,6 +2,7 @@
#define _TRACE_SKB_H
#include <linux/skbuff.h>
+#include <linux/netdevice.h>
#include <linux/tracepoint.h>
#undef TRACE_SYSTEM
@@ -34,6 +35,25 @@ TRACE_EVENT(kfree_skb,
__entry->skbaddr, __entry->protocol, __entry->location)
);
+TRACE_EVENT(skb_copy_datagram_iovec,
+
+ TP_PROTO(const struct sk_buff *skb, int len),
+
+ TP_ARGS(skb, len),
+
+ TP_STRUCT__entry(
+ __field( const void *, skbaddr )
+ __field( int, len )
+ ),
+
+ TP_fast_assign(
+ __entry->skbaddr = skb;
+ __entry->len = len;
+ ),
+
+ TP_printk("skbaddr=%p len=%d", __entry->skbaddr, __entry->len)
+);
+
#endif /* _TRACE_SKB_H */
/* This part must be outside protection */
diff --git a/net/core/datagram.c b/net/core/datagram.c
index b0fe692..1c6cf3a 100644
--- a/net/core/datagram.c
+++ b/net/core/datagram.c
@@ -55,6 +55,7 @@
#include <net/checksum.h>
#include <net/sock.h>
#include <net/tcp_states.h>
+#include <trace/events/skb.h>
/*
* Is a socket 'connection oriented' ?
@@ -284,6 +285,8 @@ int skb_copy_datagram_iovec(const struct sk_buff *skb, int offset,
int i, copy = start - offset;
struct sk_buff *frag_iter;
+ trace_skb_copy_datagram_iovec(skb, len);
+
/* Copy header. */
if (copy > 0) {
if (copy > len)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-08-08 23:14 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-07 20:21 [PATCH 0/3] net: Add ftracer to help optimize process scheduling based on incomming frame allocations Neil Horman
2009-08-07 20:28 ` [PATCH 1/3] " Neil Horman
2009-08-07 20:30 ` [PATCH 2/3] " Neil Horman
2009-08-07 20:44 ` [PATCH 3/3] " Neil Horman
2009-08-08 23:13 ` [PATCH 0/3] net: Add ftracer to help optimize process scheduling based on incomming frame allocations (v2) Neil Horman
2009-08-08 23:14 ` Neil Horman [this message]
2009-08-08 23:15 ` [PATCH 2/3] " Neil Horman
2009-08-08 23:15 ` [PATCH 3/3] " Neil Horman
2009-08-13 5:15 ` [PATCH 0/3] net: Add ftracer to help optimize process scheduling based on incomming frame allocations David Miller
2009-08-13 10:42 ` Neil Horman
2009-08-13 14:59 ` [PATCH 0/3] net: Add ftracer to help optimize process scheduling based on incomming frame allocations (v3) Neil Horman
2009-08-13 15:19 ` [PATCH 1/3] net: skb ftracer - add tracepoint to skb_copy_datagram_iovec (v3) Neil Horman
2009-08-13 23:28 ` David Miller
2009-08-13 15:20 ` [PATCH 2/3] net: skb ftracer - Add config option to enable new ftracer (v3) Neil Horman
2009-08-13 23:28 ` David Miller
2009-08-13 15:23 ` [PATCH 3/3] net: skb ftracer - Add actual ftrace code to kernel (v3) Neil Horman
2009-08-13 23:28 ` David Miller
2009-08-17 20:55 ` Steven Rostedt
2009-08-18 16:39 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090808231434.GB24414@localhost.localdomain \
--to=nhorman@tuxdriver.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).